Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: svelte $props.id #2327

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Mar 9, 2025

📝 Description

Recommends $props.id in examples

⛳️ Current behavior (updates)

Everywhere "1" is used as an ID, this will obviously conflict if the examples are taken literally, Svelte now exposes $props.id, we should recommend users to use that (similar to useId in React).

🚀 New behavior

Adds $props.id to the docs

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

See: https://svelte.dev/docs/svelte/$props#$props.id()

Copy link

changeset-bot bot commented Mar 9, 2025

⚠️ No Changeset found

Latest commit: cfa9237

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Mar 9, 2025 3:30pm
zag-solid ✅ Ready (Inspect) Visit Preview Mar 9, 2025 3:30pm
zag-svelte ✅ Ready (Inspect) Visit Preview Mar 9, 2025 3:30pm
zag-vue ✅ Ready (Inspect) Visit Preview Mar 9, 2025 3:30pm
zag-website ✅ Ready (Inspect) Visit Preview Mar 9, 2025 3:30pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant