fix(hover-card): add missing type attribute to getTriggerProps #2234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add missing
type: 'button'
attribute to thegetTriggerProps
function for thehover-card
machine.⛳️ Current behavior (updates)
The current
getTriggerProps
function does not return thetype: 'button'
attribute causing the HTML button element to not have thetype="button"
attribute. Without this attribute, the button's default behavior is like a "submit" button which is not the desired behavior.🚀 New behavior
Now the HTML button element have the
type="button"
attribute properly added, so it won't submit the closest form on click.💣 Is this a breaking change (Yes/No):
No