Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hover-card): add missing type attribute to getTriggerProps #2234

Closed

Conversation

fseglard
Copy link
Contributor

📝 Description

Add missing type: 'button' attribute to the getTriggerProps function for the hover-card machine.

⛳️ Current behavior (updates)

The current getTriggerProps function does not return the type: 'button' attribute causing the HTML button element to not have the type="button" attribute. Without this attribute, the button's default behavior is like a "submit" button which is not the desired behavior.

🚀 New behavior

Now the HTML button element have the type="button" attribute properly added, so it won't submit the closest form on click.

💣 Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 306f7fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 73 packages
Name Type
@zag-js/hover-card Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/svelte Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/angle-slider Patch
@zag-js/avatar Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/clipboard Patch
@zag-js/collapsible Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/floating-panel Patch
@zag-js/menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/progress Patch
@zag-js/qr-code Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/select Patch
@zag-js/signature-pad Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/steps Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/time-picker Patch
@zag-js/timer Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/tooltip Patch
@zag-js/tour Patch
@zag-js/tree-view Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-query Patch
@zag-js/element-rect Patch
@zag-js/element-size Patch
@zag-js/file-utils Patch
@zag-js/focus-trap Patch
@zag-js/focus-visible Patch
@zag-js/highlight-word Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/live-region Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/scroll-snap Patch
@zag-js/stringify-state Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Feb 13, 2025 2:43pm
zag-solid ❌ Failed (Inspect) Feb 13, 2025 2:43pm
zag-svelte ❌ Failed (Inspect) Feb 13, 2025 2:43pm
zag-vue ❌ Failed (Inspect) Feb 13, 2025 2:43pm
zag-website ❌ Failed (Inspect) Feb 13, 2025 2:43pm

@segunadebayo
Copy link
Member

segunadebayo commented Feb 13, 2025

Thanks for this PR.

HoverCard is a nuance component that might be used on a link, button, text, etc.

We left this to the userland to add the type:button as needed

@fseglard fseglard deleted the fix-hovercard-trigger-missing-type branch February 13, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants