Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(artifacts): ArtifactMap #2646

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

astahmer
Copy link
Collaborator

@astahmer astahmer commented Jun 2, 2024

it mostly makes it way easier to track (config) dependencies (= which config.xxx path change on HMR should trigger a new codegen for a given file) for each artifacts

typings got improved, map.getFile("xxx") will suggest any PossibleArtifact (= an ArtifactFileId that might be generated given a combination of config flags like jsxFramework, recipes, syntax ..)

when an ArtifactFile is generated, any other ArtifactFileId used in the imports (or importTypes) will also be used to transitively generated its (file) dependencies

Ideally, I'd like to find a way to make this ArtifactMap available in some hook so that any user could use it as a (very minimal) template engine with the code method and computed arguments of each ArtifactFile but this might prove a challenge due to the @pandacss/types package not knowing about the Context from @pandacss/core

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Jul 6, 2024 3:59pm
panda-playground ✅ Ready (Inspect) Visit Preview Jul 6, 2024 3:59pm
panda-studio ✅ Ready (Inspect) Visit Preview Jul 6, 2024 3:59pm

Copy link

changeset-bot bot commented Jun 2, 2024

⚠️ No Changeset found

Latest commit: c089faa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant