Issue#829: class extends null should bind this #2327
Conversation
|
This is addressing |
|
@boingoing @Microsoft/chakra-es @Microsoft/chakra-developers could you take a look please? |
|
Looks good, just make sure the Regex failures are OK |
|
@dotnet-bot test Windows ci_slow_x64_debug Windows 7 ci_dev12_x64_debug please |
|
@dotnet-bot test Windows 7 ci_dev12_x64_debug please |
|
@dotnet-bot |
|
@mmitche Do you know why the checks I added in a separate branch (release/1.4-ci) (see #2326) have been created for this branch? I was hoping to stage that change but not have it applied to all branches yet. I'll double check that I don't have a bug in my script. @suwc Note: those failures are due to #2316 , revealed by the change I added to release/1.4-ci (was testing that in #2326) |
|
@dilijev thanks. Good to know. |
|
You can now resolve the CI issues as described here: #2332 (comment) |
A class that extends null should have 'this' binding in its constructor same as a base class. Add new function attribute 'BaseConstructorKind' to capture 'extends null' cases during class definition evaluation. Add new opcode for branching on 'extends null' scenario for 'this' binding.
Merge pull request #2327 from suwc:build/suwc/buddy A class that extends null should have 'this' binding in its constructor same way as a base class. Add new function attribute 'BaseConstructorKind' to capture 'extends null' cases during class definition evaluation. Add new opcode for branching on 'extends null' scenario for 'this' binding. Fixes #829
… bind this Merge pull request #2327 from suwc:build/suwc/buddy A class that extends null should have 'this' binding in its constructor same way as a base class. Add new function attribute 'BaseConstructorKind' to capture 'extends null' cases during class definition evaluation. Add new opcode for branching on 'extends null' scenario for 'this' binding. Fixes #829
5 participants
A class that extends null should have 'this' binding in its constructor same way as a base class. Add new function attribute 'BaseConstructorKind' to capture 'extends null' cases during class definition evaluation. Add new opcode for branching on 'extends null' scenario for 'this' binding.
Fixes #829