Skip to content

[Merge release/1.4-ci to release/1.4 after #2316 is fixed] Test config of new PR checks (x64_debug for Slow, NoJIT, Legacy) #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dilijev wants to merge 1 commit into from
Closed

[Merge release/1.4-ci to release/1.4 after #2316 is fixed] Test config of new PR checks (x64_debug for Slow, NoJIT, Legacy) #2326

dilijev wants to merge 1 commit into from

Conversation

@dilijev
Copy link
Contributor

@dilijev dilijev commented Jan 6, 2017 •
edited
Loading 

[ 6b2c4e72a ] 2017-01-05 18:11 doilij@m.. Test changes to CI.
[ 4b70ccc89 ] 2017-01-05 18:09 doilij@m.. Add one PR check per daily flavor as a quality gate.
[ 22676601f ] 2017-01-05 15:29 doilij@m.. Refactor CreateBuildTasks to call CreateBuildTask to allow re-use of that logic.

Compare changes which address #2229:
https://github.com/Microsoft/ChakraCore/compare/release/1.4...release/1.4-ci?w=1

/cc @obastemur @boingoing @Cellule

@boingoing: Once #2316 is fixed, please open a new PR from release/1.4-ci to release/1.4 and merge it in to enable coverage.

@dilijev dilijev self-assigned this Jan 6, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Jan 6, 2017

@dotnet-bot test ci please

This was referenced Jan 6, 2017
Closed
Open
@dilijev
Copy link
Contributor Author

dilijev commented Jan 6, 2017

@dotnet-bot test this please

@dilijev
Copy link
Contributor Author

dilijev commented Jan 6, 2017

Failures are due to #2316 - once resolved, this change works!

@dilijev dilijev mentioned this pull request Jan 6, 2017
Merged
@dilijev
Copy link
Contributor Author

dilijev commented Jan 6, 2017

@dotnet-bot test ci please

@dilijev dilijev changed the title Test changes to CI. [Merge to release/1.4 after #2316 is fixed] Test config of new PR checks (x64_debug for Slow, NoJIT, Legacy) Jan 13, 2017
@dilijev dilijev changed the title [Merge to release/1.4 after #2316 is fixed] Test config of new PR checks (x64_debug for Slow, NoJIT, Legacy) [Merge release/1.4-ci to release/1.4 after #2316 is fixed] Test config of new PR checks (x64_debug for Slow, NoJIT, Legacy) Jan 13, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Jan 13, 2017

@boingoing: Once #2316 is fixed, please open a new PR from release/1.4-ci to release/1.4 and merge it in to enable coverage.

@dilijev dilijev assigned boingoing and unassigned dilijev Jan 13, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Jan 30, 2017

#2316 is fixed so I'm going to merge in the new configs once I confirm there are no issues.

@dotnet-bot
test this please
test dailies please

@dilijev
Copy link
Contributor Author

dilijev commented Jan 30, 2017

@dotnet-bot
test slow tests please
test linux tests please
test dev12 tests please

@dilijev dilijev self-assigned this Jan 30, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Jan 30, 2017

This PR is stale. Replacing with actual PR from release/1.4-ci to release/1.4: #2432

@dilijev dilijev closed this Jan 30, 2017
@dilijev dilijev deleted the ci-extra branch January 30, 2017 18:50
@dilijev dilijev removed their assignment Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@boingoing boingoing

Labels

Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dilijev @boingoing @msftclas