Skip to content

CFE-4518: Added CFEngine ID in cf-remote info #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

CFE-4518: Added CFEngine ID in cf-remote info #132

merged 1 commit into from
May 22, 2025

Conversation

@victormlg
Copy link
Contributor

@victormlg victormlg commented Apr 23, 2025 •
edited
Loading

cf-remote info before change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (master)$ python3 cf_remote info -H hubbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise)
Policy server : None (not bootstrapped yet)
Binaries      : dpkg, apt

cf-remote info after change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (cfengine_id)$ python3 cf_remote info -H hubbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise)
Policy server : None (not bootstrapped yet)
CFEngine ID   : SHA=478526c182bceec13f27c45aa6be6ac0bad9255c2d2a589f80fd5a9a872d4e0e
Binaries      : dpkg, apt

@victormlg victormlg requested a review from olehermanse April 23, 2025 13:06
olehermanse
olehermanse requested changes Apr 24, 2025
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to be consistent with naming, you put hostkey in some places and host_key in other places. Also aligning internal names with what we show in the output, in the UI, etc. is good.

@victormlg victormlg requested a review from olehermanse April 25, 2025 08:41
olehermanse
olehermanse requested changes Apr 25, 2025
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, please show in the PR description how it looks now.

@victormlg victormlg requested a review from larsewi May 8, 2025 09:08
@larsewi larsewi requested a review from jakub-nt May 8, 2025 17:53
larsewi
larsewi reviewed May 12, 2025
View reviewed changes
@larsewi larsewi mentioned this pull request May 12, 2025
Merged
@victormlg victormlg force-pushed the cfengine_id branch 2 times, most recently from 2f5d4f6 to 143a075 Compare May 21, 2025 11:29
@victormlg
Added CFEngine ID in cf-remote info
64eeeda 
Ticket: CFE-4518
Signed-off-by: Victor Moene <[email protected]>
@victormlg victormlg requested a review from olehermanse May 21, 2025 11:33
@olehermanse olehermanse merged commit 2381db6 into cfengine:master May 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsewi larsewi larsewi left review comments

@olehermanse olehermanse olehermanse approved these changes

@jakub-nt jakub-nt jakub-nt approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victormlg @olehermanse @larsewi @jakub-nt