Skip to content

CFE-3919: Added role in cf-remote info #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

CFE-3919: Added role in cf-remote info #134

merged 2 commits into from
May 20, 2025

Conversation

@victormlg
Copy link
Contributor

@victormlg victormlg commented Apr 25, 2025 •
edited
Loading

Hub before change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (master)$ python3 cf_remote info -H hubbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise)
Policy server : None (not bootstrapped yet)
Binaries      : dpkg, apt

Hub after change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (role-info)$ python3 cf_remote info -H hubbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise hub)
Policy server : None (not bootstrapped yet)
Binaries      : dpkg, apt

Client before change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (master)$ python3 cf_remote info -H clientbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise)
Policy server : None (not bootstrapped yet)
Binaries      : dpkg, apt

Client after change:

(.venv) victor-moene@victomoe:~/northern.tech/cf-remote (role-info)$ python3 cf_remote info -H clientbefore

[email protected]
OS            : Ubuntu 20
Architecture  : x86_64
CFEngine      : 3.24.1 (Enterprise client)
Policy server : None (not bootstrapped yet)
Binaries      : dpkg, apt

olehermanse
olehermanse requested changes Apr 25, 2025
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show the output in the PR description. Before and after, hub and client.

@victormlg victormlg requested a review from larsewi May 8, 2025 09:08
@larsewi larsewi requested a review from jakub-nt May 8, 2025 17:53
jakub-nt
jakub-nt requested changes May 9, 2025
View reviewed changes
larsewi
larsewi reviewed May 12, 2025
View reviewed changes
@victormlg
Added function cf_path to nt-discovery
34b1c08 
cf_path is a helper function to get the correct path of a cf component

Signed-off-by: Victor Moene <[email protected]>
@victormlg victormlg requested review from jakub-nt and olehermanse May 14, 2025 10:02
@olehermanse olehermanse requested a review from craigcomstock May 15, 2025 16:49
olehermanse
olehermanse reviewed May 15, 2025
View reviewed changes
olehermanse
olehermanse reviewed May 15, 2025
View reviewed changes
@victormlg
Added role in cf-remote info
de02b4a 
Ticket: CFE-3919
Signed-off-by: Victor Moene <[email protected]>
@victormlg victormlg requested a review from olehermanse May 16, 2025 12:03
@olehermanse olehermanse merged commit c144d65 into cfengine:master May 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsewi larsewi larsewi left review comments

@craigcomstock craigcomstock craigcomstock approved these changes

@olehermanse olehermanse olehermanse approved these changes

@jakub-nt jakub-nt Awaiting requested review from jakub-nt

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@victormlg @craigcomstock @olehermanse @larsewi @jakub-nt