Add CFSSL Issuer to the external issuers list#792
Add CFSSL Issuer to the external issuers list#792jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
|
Hi @jayme-github. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 1c7b769 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61d445351dccd00008d5f6ca 😎 Browse the preview: https://deploy-preview-792--cert-manager-website.netlify.app/docs/configuration/external |
|
/ok-to-test |
|
Thanks for tagging @SgtCoDFish. Can you give me a hint on how to get the name |
My pleasure, thanks for the PR 😁 One way of making it work would be if you wrote the name as a code block in backticks, as you did in your comment there - (You could otherwise add the name to |
The linked issuer may be used to request certificates from Cloudflare's PKI and TLS toolkit (CFSSL). We do also mirror to GitHub if that is preferred: https://github.com/wikimedia/operations-software-cfssl-issuer Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
|
Thanks! |
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
Thanks very much for adding this @jayme-github, looks great! 👌
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jayme-github, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The linked issuer may be used to request certificates from Cloudflare's
PKI and TLS toolkit (CFSSL).
We do also mirror to GitHub if that is preferred:
https://github.com/wikimedia/operations-software-cfssl-issuer
Signed-off-by: Janis Meybohm jmeybohm@wikimedia.org