Skip to content

Add CFSSL Issuer to the external issuers list#792

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
jayme-github:master
Jan 4, 2022
Merged

Add CFSSL Issuer to the external issuers list#792
jetstack-bot merged 1 commit intocert-manager:masterfrom
jayme-github:master

Conversation

@jayme-github
Copy link
Contributor

The linked issuer may be used to request certificates from Cloudflare's
PKI and TLS toolkit (CFSSL).

We do also mirror to GitHub if that is preferred:
https://github.com/wikimedia/operations-software-cfssl-issuer

Signed-off-by: Janis Meybohm jmeybohm@wikimedia.org

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jan 3, 2022
@jetstack-bot
Copy link
Contributor

Hi @jayme-github. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2022
@netlify
Copy link

netlify bot commented Jan 3, 2022

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 1c7b769

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61d445351dccd00008d5f6ca

😎 Browse the preview: https://deploy-preview-792--cert-manager-website.netlify.app/docs/configuration/external

@SgtCoDFish
Copy link
Member

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2022
@jayme-github
Copy link
Contributor Author

Thanks for tagging @SgtCoDFish. Can you give me a hint on how to get the name multirootca past the spell checker? It's the actual name of the CFSSL component (https://github.com/cloudflare/cfssl/blob/master/doc/cmd/multiroot.txt)

@SgtCoDFish
Copy link
Member

Thanks for tagging @SgtCoDFish. Can you give me a hint on how to get the name multirootca past the spell checker? It's the actual name of the CFSSL component (https://github.com/cloudflare/cfssl/blob/master/doc/cmd/multiroot.txt)

My pleasure, thanks for the PR 😁

One way of making it work would be if you wrote the name as a code block in backticks, as you did in your comment there - multirootca.

(You could otherwise add the name to .spelling, but I think I maybe slightly prefer it in backticks here)

The linked issuer may be used to request certificates from Cloudflare's
PKI and TLS toolkit (CFSSL).

We do also mirror to GitHub if that is preferred:
https://github.com/wikimedia/operations-software-cfssl-issuer

Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
@jayme-github
Copy link
Contributor Author

Thanks!
Putting it in backticks is absolutely fine I think.

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks very much for adding this @jayme-github, looks great! 👌

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayme-github, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@jetstack-bot jetstack-bot merged commit b2cb55f into cert-manager:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants