Skip to content

Documentation for using reflector for cross-namespace secret sync-ing#781

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
winromulus:reflector
Jan 18, 2022
Merged

Documentation for using reflector for cross-namespace secret sync-ing#781
jetstack-bot merged 1 commit intocert-manager:masterfrom
winromulus:reflector

Conversation

@winromulus
Copy link
Contributor

Added documentation for using reflector for cross-namespace sync-ing of secrets.
There were numerous requests for documenting this with cert-manager from the extension's support channels.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2021
@jetstack-bot
Copy link
Contributor

Hi @winromulus. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2021
@netlify
Copy link

netlify bot commented Dec 19, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 9220dc5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61e6a48ac89e8e00079474a7

😎 Browse the preview: https://deploy-preview-781--cert-manager-website.netlify.app

@winromulus
Copy link
Contributor Author

/assign @maelvls

@JoshVanL
Copy link
Contributor

Thanks @winromulus, would it be possible to add a redirect here, so that links to the old page (which only contained kubed) will now be directed to this new renamed page?

@winromulus
Copy link
Contributor Author

@JoshVanL good point, I did not spot that. Adding now.

-  Included reflector as extension for sync-ing secrets (popular demand for docs)
- Added redirect for renamed pages

Signed-off-by: Romeo Dumitrescu <romeo@drc.ro>
@JoshVanL
Copy link
Contributor

Thanks @winromulus, this looks like it is doing the right thing.

/lgtm
/approve
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, winromulus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@jetstack-bot jetstack-bot merged commit 24bd0a4 into cert-manager:master Jan 18, 2022
@winromulus winromulus deleted the reflector branch January 18, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants