Skip to content

Fix incorrect indentation in documentation#775

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
tete17:Fix-selector-indentation
Dec 30, 2021
Merged

Fix incorrect indentation in documentation#775
jetstack-bot merged 1 commit intocert-manager:masterfrom
tete17:Fix-selector-indentation

Conversation

@tete17
Copy link
Contributor

@tete17 tete17 commented Dec 9, 2021

The selector field belongs to the ACMEChallengeSolver according to the api
documentation, and we should not add another entry in the list for the dns01 key

In the acme section the selector key was not properly indented.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Dec 9, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Dec 9, 2021

Hi @tete17. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2021
@netlify
Copy link

netlify bot commented Dec 9, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: befd9e9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61b23ffd2ff1c90007af9899

😎 Browse the preview: https://deploy-preview-775--cert-manager-website.netlify.app

@tete17
Fix incorrect indentation in documentation
befd9e9 
The selector field belongs to the `ACMEChallengeSolver` according to the api
documentation, and we should not add another entry in the list for the `dns01` key

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
@tete17 tete17 force-pushed the Fix-selector-indentation branch from 961d33e to befd9e9 Compare December 9, 2021 17:42
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 9, 2021
@tete17
Copy link
Contributor Author

tete17 commented Dec 9, 2021

/assign @jakexks

irbekrm
irbekrm approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting these errors and most importantly for submitting fixes! 🙏🏼

/ok-to-test
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Dec 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, tete17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2021
@jetstack-bot jetstack-bot merged commit bde393c into cert-manager:master Dec 30, 2021
@tete17 tete17 deleted the Fix-selector-indentation branch January 5, 2022 17:54
@jetstack-bot jetstack-bot mentioned this pull request Jan 19, 2022
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irbekrm irbekrm irbekrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakexks jakexks

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tete17 @jetstack-bot @irbekrm @jakexks