Skip to content

Pomerium Ingress Tutorial#764

Merged
jetstack-bot merged 8 commits intocert-manager:masterfrom
alexfornuto:pomerium-ingress
Jan 11, 2022
Merged

Pomerium Ingress Tutorial#764
jetstack-bot merged 8 commits intocert-manager:masterfrom
alexfornuto:pomerium-ingress

Conversation

@alexfornuto
Copy link
Contributor

@alexfornuto alexfornuto commented Nov 24, 2021 •
edited
Loading

This PR adds a tutorial for the Pomerium Ingress Controller to use cert-manager for both private (internal) and public staging and production certs provisioned by Let's Encrypt.

Things to note:

  • I changed ingress.md to nginx-ingress.md since it's no longer the only Ingress tutorial, but I recognize that this may require adding a redirect or other intervention to prevent breaking links. I kept it in a separate commit to remove easily if needed.
  • This tutorial uses a mix of Markdown and HTML. According to Hugo docs-via-issues*, HTML is the only way to have an embedded file code block indent into an ordered list.

* Sources:

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Nov 24, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 24, 2021

Hi @alexfornuto. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2021
@netlify
Copy link

netlify bot commented Nov 24, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: aa8e5d2

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61ddceee3b7ab7000a63c471

😎 Browse the preview: https://deploy-preview-764--cert-manager-website.netlify.app/docs/tutorials/acme/pomerium-ingress

@alexfornuto
rename ingress.md to nginx-ingress
d4f0837 
Since this is no longer the only ingress doc in the directory

Signed-off-by: Alex Fornuto <alex@fornuto.com>
@alexfornuto
init Pomerium Ingress doc
fe4cc5d 
Still a WIP at this stage

complete Pomerium Ingress tutorial

Apply suggestions from code review

Co-authored-by: Travis Groth <travisgroth@users.noreply.github.com>

fix indents

one more

update config yaml

indent and title fix

Signed-off-by: Alex Fornuto <alex@fornuto.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Nov 24, 2021
Add link to Pomerium main site
f17c5e1 
Per @desimone.

Signed-off-by: Alex Fornuto <alex@fornuto.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 24, 2021
wallrj
wallrj approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexfornuto

I'll enable the tests and then try following the instructions myself.

/approve
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Dec 3, 2021
add trailing slash to index listing
e398788 
Signed-off-by: Alex Fornuto <alex@fornuto.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 3, 2021
alexfornuto added 2 commits December 3, 2021 16:20
Add Pomerium to .spelling
f4cd66d 
Signed-off-by: alexfornuto <afornuto@pomerium.com>
More spelling adjustments
ec6f8cc 
Signed-off-by: alexfornuto <afornuto@pomerium.com>
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jan 6, 2022
@desimone
Copy link

desimone commented Jan 10, 2022

👋 @wallrj -- following up on this. Anything we can do on our side to be helpful? Would love to have this included as we plan to announce the ingress controller this week!

update example output
5c49e93 
Update pomerium-ingress.md

Update pomerium-ingress.md

Update pomerium-ingress.md

Update pomerium-ingress.md

Signed-off-by: alexfornuto <afornuto@pomerium.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 10, 2022
jakexks
jakexks reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really nicely formatted tutorial, thanks! I went through and tried the links (with the deploy preview URL instead of cert-manager.io) and they seem to work. Just one comment:

Update content/en/docs/tutorials/acme/pomerium-ingress.md
aa8e5d2 
Signed-off-by: alexfornuto <afornuto@pomerium.com>
jakexks
jakexks approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this contribution!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2022
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jan 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexfornuto, jakexks, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@jetstack-bot jetstack-bot merged commit 41b6fb5 into cert-manager:master Jan 11, 2022
@jetstack-bot jetstack-bot mentioned this pull request Jan 19, 2022
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks approved these changes

@wallrj wallrj wallrj approved these changes

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexfornuto @jetstack-bot @desimone @jakexks @wallrj