Skip to content

fix broken links#757

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
oke-py:supported-releases-broken-links
Dec 30, 2021
Merged

fix broken links#757
jetstack-bot merged 1 commit intocert-manager:masterfrom
oke-py:supported-releases-broken-links

Conversation

@oke-py
Copy link
Contributor

@oke-py oke-py commented Nov 13, 2021

Signed-off-by: Naoki Oketani okepy.naoki@gmail.com

Signed-off-by: Naoki Oketani <okepy.naoki@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 13, 2021
@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: daba0e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618fc04ad83dbf0008a0b40b

😎 Browse the preview: https://deploy-preview-757--cert-manager-website.netlify.app/docs/installation/supported-releases

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2021
@jetstack-bot
Copy link
Contributor

Hi @oke-py. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2021
@oke-py
Copy link
Contributor Author

oke-py commented Nov 13, 2021

/assign @JoshVanL

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting these @oke-py

I wonder why our link checker didn't alert us about this?

/ok-to-test
/approve

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2021
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, oke-py, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2021
@jetstack-bot jetstack-bot merged commit 39b237a into cert-manager:master Dec 30, 2021
@oke-py oke-py deleted the supported-releases-broken-links branch December 30, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants