Skip to content

Revert "redirect all 404s to the root of the site"#756

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:redir404-revert
Nov 10, 2021
Merged

Revert "redirect all 404s to the root of the site"#756
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:redir404-revert

Conversation

@SgtCoDFish
Copy link
Member

This reverts commit d7e8f9e.

It didn't have the desired effect, so no reason to keep it!

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: f4f9843

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618beb9836980400086889bf

😎 Browse the preview: https://deploy-preview-756--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2021
This reverts commit d7e8f9e.

It didn't have the desired effect, so no reason to keep it!

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 10, 2021
@irbekrm
Copy link
Contributor

irbekrm commented Nov 10, 2021

Sad it didn't work

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b90f257 into cert-manager:master Nov 10, 2021
@SgtCoDFish SgtCoDFish deleted the redir404-revert branch April 26, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants