Redirect all 404s to the root of the site#755
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Nov 10, 2021
Merged
Redirect all 404s to the root of the site#755jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
jetstack-bot
added
kind/cleanup
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: d7e8f9e 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618be11ed17bac00072c8521 😎 Browse the preview: https://deploy-preview-755--cert-manager-website.netlify.app |
jetstack-bot
added
the
size/XS
Contributor
|
Looks good, I think there's no other way to prove for sure than to try it 😄 /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is required because the theme we use uses relative links for CSS files, which break if the 404 page isn't served from the root.
Currently a 404 on the root looks vaguely correct while a 404 under /docs looks totally broken. This should hopefully fix that.
This line was taken from the hugo docs. The netlify docs seem to contradict and suggest that this line is not needed, but I think it's only not needed if the 404 page uses absolute paths.
/kind cleanup