Broaden redirect for "latest/tasks" path on old docs site#754
Broaden redirect for "latest/tasks" path on old docs site#754jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 37f3660 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618bb1417e9259000758c453 😎 Browse the preview: https://deploy-preview-754--cert-manager-website.netlify.app |
|
I think this will mean that that URL redirects to |
_redirects
Outdated
| https://docs.cert-manager.io/en/latest/getting-started/index.html https://cert-manager.io/docs/tutorials/ | ||
| https://docs.cert-manager.io/en/latest/tutorials/acme/index.html https://cert-manager.io/docs/tutorials/ | ||
| https://docs.cert-manager.io/en/latest/tasks/issuers/index.html https://cert-manager.io/docs/configuration/ | ||
| https://docs.cert-manager.io/en/latest/tasks/issuers/* https://cert-manager.io/docs/configuration/ |
There was a problem hiding this comment.
you'll need to add the :splat if you wish for the path to be added to the redirected URL - ie
https://docs.cert-manager.io/en/latest/tasks/issuers/* https://cert-manager.io/docs/configuration/:splat
There was a problem hiding this comment.
That wasn't my intention, no. There's no obvious mapping of the names of individual html pages on the docs.cert-manager.io site to pages under https://cert-manager.io/docs/ - I think using :splat would be the incorrect behaviour here?
I wouldn't have expected that 🤔 I would've thought for the redirect to be to E.g. in this line we already have the redirect works as I expect. But I don't know this area well and I don't really know of a good way to test this before merging. My instinct would be to merge as-is and then I can quickly raise a new PR to fix if it's not correct |
Ah, I misunderstood the syntax, sorry. This redirect therefore takes the link to configure a CA issuer and just points to the config section, do we want |
jakexks
left a comment
There was a problem hiding this comment.
/lgtm
/hold
I think we should merge this, (but it's always a bit scary as you can't test it)
We should also update the actual Kubernetes website.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That's a fair point - we can do better with the redirects. From looking at an old wayback machine crawl I can see these pages are guides for setting up issuers - I'll add redirects for each individual issuer. |
these are based on a wayback machine crawl of the old site Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
481d54e to
37f3660
Compare
|
/unhold (we'll see if this gets us to a happy place; I can easily raise another if needed) |
|
... it redirects to https://cert-manager.io/docs/en/latest/tasks/issuers/setup-ca.html now, flying in the face of all logic I'd expected 😂 EDIT: maybe not, looks like it took a little time to propagate correctly inside netlify. https://docs.cert-manager.io/en/latest/tasks/issuers/setup-ca.html is fixed now. |
This is intended to fix a broken link under https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-certs/#set-up-a-signer which points to https://docs.cert-manager.io/en/latest/tasks/issuers/setup-ca.html
Thanks to Jon for reporting!
/kind cleanup