Skip to content

adding redirect rules to prevent google links from reaching page not …#747

Merged
jetstack-bot merged 5 commits intocert-manager:masterfrom
chance19:seo-docs-redirects
Nov 4, 2021
Merged

adding redirect rules to prevent google links from reaching page not …#747
jetstack-bot merged 5 commits intocert-manager:masterfrom
chance19:seo-docs-redirects

Conversation

@chance19
Copy link
Contributor

@chance19 chance19 commented Nov 3, 2021

…found

Signed-off-by: Chance Whittaker chance19@gmail.com

Currently some links from Google, such as https://docs.cert-manager.io/en/release-0.11/ would route to https://cert-manager.io/docs/en/release-0.11/ which would take the browser to a 404 page not found (see screenshot)
image

This change should ensure that these links are at least routed back to the specific release-note page that was referenced in the link. This is not a full solution to the problem just an improvement on the current situation.

…found

Signed-off-by: Chance Whittaker <chance19@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2021
@netlify
Copy link

netlify bot commented Nov 3, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 42d3bff

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61841a89d1f69d000746b82b

😎 Browse the preview: https://deploy-preview-747--cert-manager-website.netlify.app

@chance19
Copy link
Contributor Author

chance19 commented Nov 4, 2021

CC @mattbates for visibility

Signed-off-by: Chance Whittaker <chance19@gmail.com>
Signed-off-by: Chance Whittaker <chance19@gmail.com>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2021
@chance19
Copy link
Contributor Author

chance19 commented Nov 4, 2021

Three commits:

  1. Adding more specific redirect rules to mitigate 404 errors
  2. Updating outdated links in content
  3. Adding specific links from outside sources (https://www.fairwinds.com/blog/upgrade-cert-manager-its-worth-it) that needed to be redirected and applying contextual comments

@SgtCoDFish
Copy link
Member

Happy to review this once the conflicts have been resolved 👍

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Nov 4, 2021
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, there's just one little thing I've raised.

There are a lot of references to docs.cert-manager.io if I do grep -R "docs\.cert-manager\.io" . in the website repo, but most are in old docs and they should be caught by the redirect rules we're adding here 👍

Signed-off-by: Chance Whittaker <chance19@gmail.com>
Signed-off-by: Chance Whittaker <chance19@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 4, 2021
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good stuff 😁

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chance19, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@jetstack-bot jetstack-bot merged commit 551a25e into cert-manager:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants