Skip to content

Remove references to removed API versions#745

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:removed_apis_refs
Nov 4, 2021
Merged

Remove references to removed API versions#745
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:removed_apis_refs

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Nov 3, 2021

This PR changes references to the deprecated alpha/beta API resources to refer to v1 resources instead.

I would also like to cherry-pick this PR into release-1.6 branch so that #744 which is currently failing passes.

Signed-off-by: irbekrm irbekrm@gmail.com

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2021
@netlify
Copy link

netlify bot commented Nov 3, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: a0601ab

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61821fb377081d000717faa6

😎 Browse the preview: https://deploy-preview-745--cert-manager-website.netlify.app

@irbekrm
Copy link
Contributor Author

irbekrm commented Nov 3, 2021

/cherry-pick release-1.6

@jetstack-bot
Copy link
Contributor

@irbekrm: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 5d03b4f into cert-manager:master Nov 4, 2021
@jetstack-bot
Copy link
Contributor

@irbekrm: new pull request created: #749

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants