Skip to content

Add an upgrade 1.5 to 1.6 document#737

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:1.6-upgrade-doc
Oct 28, 2021
Merged

Add an upgrade 1.5 to 1.6 document#737
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:1.6-upgrade-doc

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Oct 27, 2021

No description provided.

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 27, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 27, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 3391084

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6179a8881d372200083d3979

😎 Browse the preview: https://deploy-preview-737--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2021
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2021
jakexks
jakexks reviewed Oct 27, 2021
View reviewed changes
content/en/docs/installation/upgrading/upgrading-1.5-1.6.md Outdated
Following their deprecation in version 1.4, the cert-manager API versions `v1alpha2, v1alpha3, and v1beta1` are no longer served.

This means if your deployment manifests contain any of these API versions, you will not be able to deploy them after upgrading.
Our new `cmctl` utility or old `kubectl cert-manager` plugin can [convert](https://cert-manager.io/docs/usage/kubectl-plugin/#convert) old manifests to `v1` for you.
Copy link
Copy Markdown
Member

@jakexks jakexks Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we convert this to a relative link? For better or worse we just removed a lot of absolute links because they cause issues when we generate old versions of the documentation in the hypothetical future when the page title changes

jakexks
jakexks reviewed Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about converting absolute links to relative links

@wallrj wallrj force-pushed the 1.6-upgrade-doc branch 2 times, most recently from a85256a to 8434607 Compare October 27, 2021 19:14
@wallrj
Add an upgrade 1.5 to 1.6 document
3391084 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj requested a review from jakexks October 28, 2021 07:52
@wallrj wallrj changed the title WIP: Add an upgrade 1.5 to 1.6 document Add an upgrade 1.5 to 1.6 document Oct 28, 2021
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021
jakexks
jakexks approved these changes Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks again!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@jetstack-bot jetstack-bot merged commit cd0c89d into cert-manager:master Oct 28, 2021
@wallrj wallrj deleted the 1.6-upgrade-doc branch October 28, 2021 09:03
@jetstack-bot jetstack-bot mentioned this pull request Dec 3, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj @jetstack-bot @jakexks