Update kubed sync example and use secret template instead of pre-annotated secret#727
Conversation
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: fa61085 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618230f7435f910007fa0bb2 😎 Browse the preview: https://deploy-preview-727--cert-manager-website.netlify.app |
|
Hi @AljoschaP. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
irbekrm
left a comment
There was a problem hiding this comment.
Hi @AljoschaP,
Thank you very much for the contribution!
I've added a minor nit about linking to v1 API version, apart from that this is a very useful change 👍🏼
/ok-to-test
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
|
/retest |
|
Thanks for making the changes! This now looks good to me 👍🏼 Just needs the last three commits to be signed to get passed the CI tests 😅 |
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
0d8e62f to
fa61085
Compare
Should be okay now 😃 Thank you 👍 |
|
Thanks for working on this! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AljoschaP, irbekrm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because the use of pre-annotated secrets for syncing certificates across namespaces is error-prone and
secretTemplateis available since 1.5.0, this PR updates the kubed example for syncing secrets to usesecretTemplateinstead of pre-created secrets.