Skip to content

Update kubed sync example and use secret template instead of pre-annotated secret#727

Merged
jetstack-bot merged 5 commits intocert-manager:masterfrom
aljoshare:update-kubed-sync-example-by-using-secret-template
Nov 3, 2021
Merged

Update kubed sync example and use secret template instead of pre-annotated secret#727
jetstack-bot merged 5 commits intocert-manager:masterfrom
aljoshare:update-kubed-sync-example-by-using-secret-template

Conversation

@aljoshare
Copy link
Contributor

Because the use of pre-annotated secrets for syncing certificates across namespaces is error-prone and secretTemplate is available since 1.5.0, this PR updates the kubed example for syncing secrets to use secretTemplate instead of pre-created secrets.

Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 26, 2021
@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: fa61085

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/618230f7435f910007fa0bb2

😎 Browse the preview: https://deploy-preview-727--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2021
@jetstack-bot
Copy link
Contributor

Hi @AljoschaP. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2021
@aljoshare aljoshare changed the title Update kubed sync example by using secret template Update kubed sync example and use secret template instead of pre-annotated secret Oct 26, 2021
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AljoschaP,

Thank you very much for the contribution!

I've added a minor nit about linking to v1 API version, apart from that this is a very useful change 👍🏼

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2021
Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Nov 2, 2021
@aljoshare
Copy link
Contributor Author

/retest

@irbekrm
Copy link
Contributor

irbekrm commented Nov 3, 2021

Thanks for making the changes! This now looks good to me 👍🏼

Just needs the last three commits to be signed to get passed the CI tests 😅

Signed-off-by: Aljoscha Poertner <aljoscha.poertner@hellmann.com>
@aljoshare aljoshare force-pushed the update-kubed-sync-example-by-using-secret-template branch from 0d8e62f to fa61085 Compare November 3, 2021 06:49
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 3, 2021
@aljoshare
Copy link
Contributor Author

Thanks for making the changes! This now looks good to me 👍🏼

Just needs the last three commits to be signed to get passed the CI tests sweat_smile

Thanks for making the changes! This now looks good to me 👍🏼

Just needs the last three commits to be signed to get passed the CI tests sweat_smile

Should be okay now 😃 Thank you 👍

@irbekrm
Copy link
Contributor

irbekrm commented Nov 3, 2021

Thanks for working on this!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AljoschaP, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@jetstack-bot jetstack-bot merged commit 00bbe2c into cert-manager:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants