Change links in usage certificate to kubectl plugin #renew to be relative#723
Merged
jetstack-bot merged 1 commit intocert-manager:release-nextfrom Oct 26, 2021
Conversation
…tive Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
jetstack-bot
added
the
do-not-merge/cherry-pick-not-approved
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 2b03369 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6177cb4ee7f8930007effb50 😎 Browse the preview: https://deploy-preview-723--cert-manager-website.netlify.app/docs/usage/certificate |
jetstack-bot
added
dco-signoff: yes
Member
|
/lgtm |
jakexks
added
cherry-pick-approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #718
/assign @jakexks
This PR changes references in release-1.5/usage/certificate to usage/kubectl-plugin/#renew to use a relative path. When using an absolute path, it looks like it will reference the latest docs, which will no longer exist after this PR #715. Changing to the relative path should now link to the page within the correct version.