DNS01 webhooks : add cert-manager-alidns-webhook#700
DNS01 webhooks : add cert-manager-alidns-webhook#700jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 491ff92 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/613f3af79aa89c0007842b16 😎 Browse the preview: https://deploy-preview-700--cert-manager-website.netlify.app/docs/configuration/acme/dns01 |
|
Hi @olivierboudet. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f0b55af to
5da89b3
Compare
5da89b3 to
40fd1ae
Compare
Signed-off-by: Olivier Boudet <o.boudet@gmail.com>
40fd1ae to
491ff92
Compare
|
/assign @jakexks |
|
Thanks for the contibution! The project looks good to me, I see docs and tests 😄 A bit curious why it was chosen to write a new webhook as I see that there is already one external webhook for alidns https://github.com/pragkent/alidns-webhook? /ok-to-test |
|
Thanks !
Just because I did the first commit before the pragkent's one :) |
|
That makes sense 👍🏼 Glad to see this going in- thanks for the contribution! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, olivierboudet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.