Skip to content

DNS01 webhooks : add cert-manager-alidns-webhook#700

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
olivierboudet:patch-1
Nov 3, 2021
Merged

DNS01 webhooks : add cert-manager-alidns-webhook#700
jetstack-bot merged 1 commit intocert-manager:masterfrom
olivierboudet:patch-1

Conversation

@olivierboudet
Copy link
Contributor

No description provided.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Sep 10, 2021
@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 491ff92

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/613f3af79aa89c0007842b16

😎 Browse the preview: https://deploy-preview-700--cert-manager-website.netlify.app/docs/configuration/acme/dns01

@jetstack-bot
Copy link
Contributor

Hi @olivierboudet. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2021
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 10, 2021
Signed-off-by: Olivier Boudet <o.boudet@gmail.com>
@olivierboudet
Copy link
Contributor Author

/assign @jakexks

@olivierboudet
Copy link
Contributor Author

/unassign @jakexks
/assign @irbekrm

@jetstack-bot jetstack-bot assigned irbekrm and unassigned jakexks Oct 1, 2021
@irbekrm
Copy link
Contributor

irbekrm commented Nov 3, 2021

Thanks for the contibution!

The project looks good to me, I see docs and tests 😄

A bit curious why it was chosen to write a new webhook as I see that there is already one external webhook for alidns https://github.com/pragkent/alidns-webhook?

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2021
@olivierboudet
Copy link
Contributor Author

Thanks !

A bit curious why it was chosen to write a new webhook as I see that there is already one external webhook for alidns https://github.com/pragkent/alidns-webhook?

Just because I did the first commit before the pragkent's one :)

@irbekrm
Copy link
Contributor

irbekrm commented Nov 3, 2021

That makes sense 👍🏼

Glad to see this going in- thanks for the contribution!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, olivierboudet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@jetstack-bot jetstack-bot merged commit 4f2ead2 into cert-manager:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants