Skip to content

Update instructions for merging the Helm chart PR #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetstack-bot merged 2 commits into from
Jun 3, 2021
Merged

Update instructions for merging the Helm chart PR #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8207c77
Update instructions for merging the Helm chart PR
wallrj May 19, 2021
80bb9cf
Fix some spell-check errors
wallrj May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .spelling
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ apiserver
APIService
APIServices
AppRole
ArtifactHUB
AWS
allowlist
awspca
Expand Down
29 changes: 20 additions & 9 deletions content/en/docs/contributing/release-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,10 @@ page if a step is missing or if it is outdated.
```

<div class="pageinfo pageinfo-warning"><p>
⏰ At this stage, there will be a draft release on GitHub and a live
release on our ChartMuseum (https://charts.jetstack.io/index.yaml).
So you must now complete the release process quickly; otherwise, users
of the latest release on our ChartMuseum instance will encounter errors
because the manual CRD install URL will not be available yet.
⏰ Upon completion there will be:

1. [A draft release of cert-manager on GitHub](https://github.com/jetstack/cert-manager/releases).
2. [A pull request containing the new Helm chart](https://github.com/jetstack/jetstack-charts/pulls).
Comment on lines +367 to +370

@SgtCoDFish SgtCoDFish Jun 3, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: love this improvement, much cleaner IMO 👍

</p></div>

5. While the build is running, send a fourth Slack message in reply to
Expand All @@ -391,18 +390,30 @@ page if a step is missing or if it is outdated.
3. Click "Publish" to make the GitHub release live. This will create a Git
tag automatically.

9. **(final release only)** Add the new final release to the
9. Merge the pull request containing the Helm chart:

The Helm charts for cert-manager are served using Cloudflare pages
and the Helm chart files and metadata are stored in the [Jetstack charts repository](https://github.com/jetstack/jetstack-charts).
The `cmrel publish --nomock` step (above) will have created a PR in this repository which you now have to review and merge, as follows:

1. [Visit the pull request](https://github.com/jetstack/jetstack-charts/pulls)
2. Review the changes
3. Fix any failing checks
4. Merge the PR
5. Check that the [cert-manager Helm chart is visible on ArtifactHUB](https://artifacthub.io/packages/helm/cert-manager/cert-manager).

10. **(final release only)** Add the new final release to the
[supported-releases](/docs/installation/supported-releases/) page.

10. Post a Slack message as an answer to the first message. Toggle the check
11. Post a Slack message as an answer to the first message. Toggle the check
box "Also send to `#cert-manager-dev`" so that the message is well
visible. Also cross-post the message on `#cert-manager`.

<div class="pageinfo pageinfo-primary"><p>
https://github.com/jetstack/cert-manager/releases/tag/v1.0.0 🎉
</p></div>

11. **(final release only)** Show the release to the world:
12. **(final release only)** Show the release to the world:

1. Send an email to
[`cert-manager-dev@googlegroups.com`](https://groups.google.com/g/cert-manager-dev)
Expand All @@ -413,7 +424,7 @@ page if a step is missing or if it is outdated.
([example](https://twitter.com/MaartjeME/status/1286327362121084928))
and make sure [@JetstackHQ](https://twitter.com/JetstackHQ) retweets it.

12. Proceed to the post-release steps:
13. Proceed to the post-release steps:

1. **(final release only)** Add the new final release to the
[supported-releases](/docs/installation/supported-releases/) page.
Expand Down