Skip to content

Update instructions for merging the Helm chart PR#565

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
wallrj:3934-cmrel-publish-helm
Jun 3, 2021
Merged

Update instructions for merging the Helm chart PR#565
jetstack-bot merged 2 commits intocert-manager:masterfrom
wallrj:3934-cmrel-publish-helm

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented May 19, 2021

Update the release-process to include instructions on how to merge the Helm chart PR at the end of a release.

xref: cert-manager/cert-manager#3934

@wallrj
Update instructions for merging the Helm chart PR
8207c77 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2021
@wallrj wallrj mentioned this pull request May 19, 2021
Closed
@SgtCoDFish
Copy link
Member

SgtCoDFish commented May 27, 2021

I went to review this and then thought it's probably best to wait until we cut the beta release tomorrow, which we could do using this PR as a guide?

@wallrj
Fix some spell-check errors
80bb9cf 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2021
@wallrj
Copy link
Member Author

wallrj commented Jun 1, 2021

We discovered that the PR created by cmrel does pass verification tests run by GitHub Action in the jetstack-charts repo.
So I've published another fix awaiting review in https://github.com/jetstack/jetstack-charts/pull/34

@wallrj wallrj requested a review from SgtCoDFish June 3, 2021 08:35
@wallrj
Copy link
Member Author

wallrj commented Jun 3, 2021

The PR created by cmrel should now be fully automated.
All the GitHub Actions should pass without any manual intervention.
All that is required is for the releaser to go and approve and merge the PR, as described in this documentation update.
PTAL.

SgtCoDFish
SgtCoDFish approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Not really much to say, this looks sound to me!

content/en/docs/contributing/release-process.md
Comment on lines +367 to +370
⏰ Upon completion there will be:

1. [A draft release of cert-manager on GitHub](https://github.com/jetstack/cert-manager/releases).
2. [A pull request containing the new Helm chart](https://github.com/jetstack/jetstack-charts/pulls).
Copy link
Member

@SgtCoDFish SgtCoDFish Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: love this improvement, much cleaner IMO 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@jetstack-bot jetstack-bot merged commit 4789ea5 into cert-manager:master Jun 3, 2021
This was referenced Jun 9, 2021
Closed
Closed
@wallrj wallrj deleted the 3934-cmrel-publish-helm branch February 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj @SgtCoDFish @jetstack-bot