This repository has been archived by the owner on May 22, 2024. It is now read-only.
Capture screenshot using viewport size instead of window size. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbcai
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
mjhenkes
approved these changes
Sep 2, 2021
jmsv6d
approved these changes
Sep 2, 2021
ryanthemanuel
approved these changes
Sep 2, 2021
BenBoersma
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The size of the viewports is currently set to the browser's window size. It should be set to the viewable screenshot size so that screenshot dimensions captured in IE is consistent.
Closes #705
Additional Details
This PR is to bring back the changes made on #673 which was intentionally removed in terra-functional-testing V2 because we opted to increase the large viewport size.
@cerner/terra