Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-functional-testing] Inconsistent IE screenshot dimension #705

Closed
benbcai opened this issue Sep 1, 2021 · 0 comments · Fixed by #706
Closed

[terra-functional-testing] Inconsistent IE screenshot dimension #705

benbcai opened this issue Sep 1, 2021 · 0 comments · Fixed by #706

Comments

@benbcai
Copy link
Contributor

benbcai commented Sep 1, 2021

Story

Description

As a maintainer of terra-functional-testing I want to set and capture the size of the screenshot using the viewport size instead of the window size

Motivation

so that the size of wdio screenshots in IE is consistent and the test can pass when matching against the reference screenshots

Definition of Done

We'll know we're done when screenshots are captured using viewport size and wdio tests can consistently pass when running in IE.

Additional Detail.

The issue is related to #671. We previously updated from viewport size to window size. In terra-functional-testing V2, we decided to revert the change and opted to resolve the issue by increasing the size for the large viewport. It turns out reverting the change still causes sizing issues in IE. We should add back the change made on PR #673.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant