This repository has been archived by the owner on May 22, 2024. It is now read-only.
[terra-functional-testing] Set test page to the viewport size instead of the browser's window size #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbcai
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
ryanthemanuel
approved these changes
Jun 17, 2021
BenBoersma
approved these changes
Jun 17, 2021
mjhenkes
added a commit
that referenced
this pull request
Jul 16, 2021
* Upgrade wdio 7 * Update all wdio dependencies * update constructor * writeStream * work around * upgrade guide * Update packages/terra-toolkit-docs/src/terra-dev-site/tool/terra-functional-testing/upgrade-guides.5/version-2-upgrade-guide.2.tool.md Co-authored-by: Ben Cai <[email protected]> * Fix merged jest tests. Code review comments * node version * Revert "[terra-functional-testing] Set test page to the viewport size instead of the browser's window size (#673)" This reverts commit 4ada1f5. * Update large test viewport * More doc updates * Update packages/terra-functional-testing/src/services/wdio-visual-regression-service/modules/getTerraFormFactor.js Co-authored-by: Matt Henkes <[email protected]> * Update CHANGELOG.md changelog oops * lint * Fix test Co-authored-by: Ben Cai <[email protected]> Co-authored-by: Matt Henkes <[email protected]>
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The size of the viewports is currently set to the browser's window size. It should be set to the viewable screenshot size (AKA viewport size).
Additional Details
Fixes #671
See issue for more details of this change.
Validation PRs:
@cerner/terra