Skip to content

Fix empty relationships on included resources #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix empty relationships on included resources #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jsonapi/resource_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def load_included(resource_klass, source_resource_tree, include_related, options
find_related_resource_options)

related_resource_tree = source_resource_tree.get_related_resource_tree(relationship)
related_resource_tree.add_resource_fragments(related_fragments, include_related[key][include_related])
related_resource_tree.add_resource_fragments(related_fragments, include_related[key][:include_related])

# Now recursively get the related resources for the currently found resources
load_included(relationship.resource_klass,
Expand Down
3 changes: 2 additions & 1 deletion test/controllers/controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4371,7 +4371,8 @@ def test_complex_includes_things_nested_things
"links" => {
"self" => "http://test.host/api/things/40/relationships/things",
"related" => "http://test.host/api/things/40/things"
}
},
"data"=>[]
}
}
},
Expand Down