Fix empty relationships on included resources #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1371
JSONAPI::ResourceTree#load_included was failing to correctly
populate the resource fragments of included resources, such that
the
include_related
parameter was null. This was resulting inthe relationships object lacking a data attribute for nil or
empty resources.
The JSON-API specification states that a null or empty array should
be returned in these circumstances:
https://jsonapi.org/format/#document-resource-object-linkage
The underlying issue appears to be the use of
include_related
ratherthan the symbol
:include_related
when initializing nested resourcefragments.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: