Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Use minikube prerelease ISO on CI #3346

Closed
wants to merge 2 commits into from
Closed

RFC: Use minikube prerelease ISO on CI #3346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dcf319
scripts: Add env to set minikube iso url
Aug 26, 2022
21c44df
build: Use minikube v1.26.1-1661377864-14783-amd64.iso
Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ HELM_VERSION=v3.9.2

# minikube settings
MINIKUBE_VERSION=v1.26.1
MINIKUBE_ISO_URL=https://storage.googleapis.com/minikube-builds/iso/14783/minikube-v1.26.1-1661377864-14783-amd64.iso
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't get updated and CI works fine, am good with this one.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @Madhu-1 concern is vaild, can we copy this to some local file server @nixpanic (I remember we supplied a native link with NBD patches before) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really want to host ISO images ourselves. If this link stays available until a next minikube version contains the fscrypt feature, I'd prefer to using this.

VM_DRIVER=none
CHANGE_MINIKUBE_NONE_USER=true

Expand Down
5 changes: 5 additions & 0 deletions scripts/minikube.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ function disable_storage_addons() {
# configure minikube
MINIKUBE_ARCH=${MINIKUBE_ARCH:-"amd64"}
MINIKUBE_VERSION=${MINIKUBE_VERSION:-"latest"}
MINIKUBE_ISO_URL=${MINIKUBE_ISO_URL:-""}
KUBE_VERSION=${KUBE_VERSION:-"latest"}
CONTAINER_CMD=${CONTAINER_CMD:-"docker"}
MEMORY=${MEMORY:-"4096"}
Expand All @@ -176,6 +177,10 @@ else
DISK_CONFIG=""
fi

if [[ -n "${MINIKUBE_ISO_URL}" ]]; then
EXTRA_CONFIG="${EXTRA_CONFIG} --iso-url ${MINIKUBE_ISO_URL}"
fi

# configure csi image version
CSI_IMAGE_VERSION=${CSI_IMAGE_VERSION:-"canary"}

Expand Down