-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Use minikube prerelease ISO on CI #3346
Conversation
Make minikube ISO URL configurable. This can be used to run minikube with public pre-release images or local images (file://) Signed-off-by: Marcel Lauhoff <[email protected]>
Use prerelease minikube ISO, which includes fscrypt support to allow fscrypt PRs to run. Revert once MINIKUBE_VERSION is updated. Signed-off-by: Marcel Lauhoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the feature, and am sure @pkalever appreciates it too. Going to default for a pre-release for everything is not that great though... At the very least, we'll need an issue to track removing the default pre-release URL once the next minikube version is available.
We use pre-releases sometimes, so I don't think it's a blocking issue.
@@ -39,6 +39,7 @@ HELM_VERSION=v3.9.2 | |||
|
|||
# minikube settings | |||
MINIKUBE_VERSION=v1.26.1 | |||
MINIKUBE_ISO_URL=https://storage.googleapis.com/minikube-builds/iso/14783/minikube-v1.26.1-1661377864-14783-amd64.iso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't get updated and CI works fine, am good with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really want to host ISO images ourselves. If this link stays available until a next minikube version contains the fscrypt feature, I'd prefer to using this.
The best option is to add it as a new commit in the PR which needs this support. |
Thanks for merging #3351. I added the two commits to the last push to #3310 and the CI system picked up the new options. The ISO is listed in the minikube logs output of the 'log system status' jenkins node. I'm closing this one in favor #3310. |
Now that minikube fscrypt kernel support is merged (kubernetes/minikube#14783), I'm looking for a way to run #3310 on the Ceph CSI CI with that ISO. A updated ISO was build and is available for download: https://storage.googleapis.com/minikube-builds/iso/14783/minikube-v1.26.1-1661377864-14783-amd64.iso
Would this be a way forward until the next minikube release?