Use blocklist and multi-gas-pools only while sequencing#363
Merged
ezdac merged 12 commits intocelo-rebase-12from Apr 8, 2025
Merged
Use blocklist and multi-gas-pools only while sequencing#363ezdac merged 12 commits intocelo-rebase-12from
ezdac merged 12 commits intocelo-rebase-12from
Conversation
ezdac
force-pushed
the
ezdac/blocklist-only-on-sequencing
branch
from
304d0fc to
cb17717
Compare
ezdac
force-pushed
the
ezdac/blocklist-only-on-sequencing
branch
from
cb17717 to
ef5955e
Compare
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
piersy
reviewed
Apr 3, 2025
ezdac
force-pushed
the
ezdac/blocklist-only-on-sequencing
branch
from
f9f8138 to
9b1ce82
Compare
We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block.
ezdac
force-pushed
the
ezdac/blocklist-only-on-sequencing
branch
3 times, most recently
from
614982d to
aa22153
Compare
Co-authored-by: piersy <pierspowlesland@gmail.com>
Co-Authored-by: piersy <pierspowlesland@gmail.com>
Co-authored-by: piersy <pierspowlesland@gmail.com>
ezdac
force-pushed
the
ezdac/blocklist-only-on-sequencing
branch
from
aa22153 to
d140fbe
Compare
Kourin1996
pushed a commit
that referenced
this pull request
Aug 5, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 5, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 6, 2025
* Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 6, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 7, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 8, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 8, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 11, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 11, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
Kourin1996
pushed a commit
that referenced
this pull request
Aug 11, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
Kourin1996
pushed a commit
that referenced
this pull request
Aug 11, 2025
This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast
karlb
pushed a commit
that referenced
this pull request
Nov 5, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
karlb
added a commit
that referenced
this pull request
Nov 5, 2025
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
karlb
pushed a commit
that referenced
this pull request
Dec 5, 2025
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
karlb
added a commit
that referenced
this pull request
Dec 5, 2025
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
karlb
pushed a commit
that referenced
this pull request
Jan 6, 2026
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
karlb
added a commit
that referenced
this pull request
Jan 6, 2026
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
piersy
pushed a commit
that referenced
this pull request
Jan 17, 2026
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
piersy
pushed a commit
that referenced
this pull request
Jan 17, 2026
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
piersy
pushed a commit
that referenced
this pull request
Jan 17, 2026
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
piersy
pushed a commit
that referenced
this pull request
Jan 17, 2026
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
piersy
pushed a commit
that referenced
this pull request
Jan 21, 2026
) * Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test
piersy
pushed a commit
that referenced
this pull request
Jan 21, 2026
This is a squash commit of all e2e testing related previous commits. e2e: Add shell based test runner (#21) * Run all test_* files * Report failure count * Handle geth start and stop * Use initialized genesis block instead of deploying token e2e: Add token duality e2e test (#3, #21) e2e: Add smoketest to e2e tests (#261) Adds an e2e smoketest that sends value transfer, contract interaction and contract creation transactions for all of the valid transaction types. It also verifies that deprecated transactions (celo legacy & cip42) are not supported. Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e: Add tests with Ethers and Viem (#42) To exercise the fee currency support and test JS lib compatibility. Closes celo-org/optimism#61 e2e(runner): Allows tests to be run on Alfajores. (#212, #258) Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(fee_currency): Reenable test_fee_currency_fails_on_credit.sh (#400) It has been disabled in d9518cc#diff-7e9dfb8659cce411851abf104e7bf34d826781fb4dc07fc9cb3a1a5b82fa5af1R48-R54, but since it works fine for me now, I don't see a reason to keep it disabled. e2e(runner): Add mainner & baklava e2e test config for easier testing (#331, #340) Run tests against baklava with `NETWORK=baklava ./run_all_tests.sh` after giving the wallet enough balance (or setting your own). e2e(js) update e2e test js dependencies (#380) e2e: Bump braces from 3.0.2 to 3.0.3 in /e2e_test/js-tests (#392) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> e2e: Add sending overlapping nonce test and CIP-64 tx test in e2e viem test (#43, #55, #293) Co-authored-by: Pastoh <hbandura@users.noreply.github.com> Co-authored-by: kourin <yoshiki.takabayashi@clabs.co> e2e(js): Loosen error check condition in e2e-test (#380) Due to possible expansion of the responses error string in potential proxy setups on a live RPC endpoint, the strict error check in the e2e viem test caused the test to fail, although the error condition was expected. e2e(js): Add test of sending CIP-64 tx with unregistered fee currency in viem e2e test e2e(js): Run e2e tests on alfajores (#212, #258, #268, #293) Adds a test of transactions that exceed the max intrinsic gas for a fee currency, this checks that the transaction fails and the fee currency is blocked. This entailed increasing gas limits for a number of transactions that interact with fee currencies, since the fee currencies on alfajores are different to our debug ones and also tests needed to be updated to not rely on hardcoded fee currency rates. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> e2e(js): Get extra intrinsic gas for custom fee currency in e2e (#335) * Get IntrinsicGas for custom fee currency in e2e * Rename function name and add comments * Add missing await * Fix wrong method call * Fix codes based reviews e2e: Extract viem initialization code into viem_setup.mjs for reuse (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(js): Add mainnet & baklava config in e2e viem setup (#331, #340) e2e: Add WebSocket support in e2e (#356) e2e: set default TERM in e2e test for tput (#380) e2e: Test fee currencies with failing debit/credit (#85) This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast e2e: Add gas estimation e2e test (#356) e2e: Add e2e test for fee handler (#36) Use Celo Sepolia for e2e test instead of alfajores The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recognized that there might be an issue that validators can't derive from L1 when it has a different local state than the block-builder / sequencer:
This is why we have to disable the blocklist and specific fee currency pools in the multigaspool while deriving from L1 (
payloadAttributes.noTxs==true).In addition to this, we also disable filtering the allowlist or adding to the blocklist while building the pending block.