Skip to content

WIP fee#398

Closed
aaronmgdr wants to merge 1 commit intomasterfrom
hotfix/pricing
Closed

WIP fee#398
aaronmgdr wants to merge 1 commit intomasterfrom
hotfix/pricing

Conversation

@aaronmgdr
Copy link
Contributor

@aaronmgdr aaronmgdr commented Oct 17, 2024

celo-org/viem#20

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Documentation

The set of community facing docs that have been added/modified because of this change


PR-Codex overview

This PR focuses on enhancing the gas fee calculation logic within the Connection class by incorporating Layer 2 (L2) considerations when determining baseFee and maxFeePerGas.

Detailed summary

  • Added the import of isCel2 from ./utils/is-cel2.
  • Introduced a new variable maxPriorityFeePerGas to handle priority fees.
  • Updated baseFee calculation for L2 to consider maxPriorityFeePerGas.
  • Adjusted logic to compute maxFeePerGas based on L1 and L2 conditions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: b528794

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.96%. Comparing base (c0c1644) to head (b528794).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c0c1644) and HEAD (b528794). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c0c1644) HEAD (b528794)
6 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #398       +/-   ##
===========================================
- Coverage   67.51%   55.96%   -11.56%     
===========================================
  Files         291      222       -69     
  Lines       10984     8012     -2972     
  Branches     1540      949      -591     
===========================================
- Hits         7416     4484     -2932     
- Misses       3445     3470       +25     
+ Partials      123       58       -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronmgdr aaronmgdr closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments