fix #1927: upgrade btcd

[palango]

Description

Upgrading some dependencies - see #1927
Ported ethereum/go-ethereum#24533 and made some extra changes to make things work.

Also this caused problems with the ios build, which was therefor disabled. This is tracked in #2000.

Other changes

Some changes ported from ethereum/go-ethereum#24533 might not have been absolutely necessary (ex. fixing a typo).

Tested

Existing tests

Related issues

• Fixes upgrade dependency on github.com/btcsuite/btcd #1927
• Resolves fix #1927: upgrade btcd #1928

Backwards compatibility

According to #24533, the changes are perfectly compatible and affect only non-cgo builds anyway. Looks like celo-blockchain can't build without cgo yet, so this is definitely not going to be an issue.

[piersy]

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 6723de7

coverage: 47.9% of statements across all listed packages

coverage:  52.9% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  56.0% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  56.4% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

CommentID: 69b72d95f7

[codecov]

Codecov Report

Base: 54.82% // Head: 54.81% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6723de7) compared to base (e831c00).
Patch coverage: 59.32% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   54.82%   54.81%   -0.02%     
==========================================
  Files         688      695       +7     
  Lines       92542    93258     +716     
==========================================
+ Hits        50737    51115     +378     
- Misses      37993    38300     +307     
- Partials     3812     3843      +31     

Impacted Files	Coverage Δ
cmd/geth/config.go	0.00% <0.00%> (ø)
cmd/geth/main.go	20.00% <ø> (ø)
cmd/utils/flags.go	2.77% <0.00%> (-0.02%)	⬇️
consensus/istanbul/config.go	0.00% <0.00%> (ø)
consensus/istanbul/core/preprepare.go	71.23% <0.00%> (+7.03%)	⬆️
contracts/gasprice_minimum/gasprice_minimum.go	45.61% <0.00%> (-14.86%)	⬇️
core/sys_context.go	78.57% <ø> (ø)
core/vm/operations_acl.go	4.44% <ø> (ø)
eth/api_backend.go	0.00% <0.00%> (ø)
eth/downloader/queue.go	80.36% <ø> (-0.56%)	⬇️
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gastonponti]

LGTM!
I would add to the PR description that we also commented the ios compilation on circle (to have a better tracking)

[palango]

I would add to the PR description that we also commented the ios compilation on circle (to have a better tracking)

Good point, created a tracking issue and mentioned it in the description.