Skip to content

perf(p2p): avoid deserialization for locally published headers #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wondertan merged 4 commits into from
Mar 31, 2025
Merged

perf(p2p): avoid deserialization for locally published headers #251

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12e4328
perf(p2p): avoid deserialization for locally published headers
Wondertan Mar 13, 2025
4e3bf0c
add option
Wondertan Mar 26, 2025
77e7ea5
fix test
Wondertan Mar 28, 2025
9d55656
Merge branch 'main' into avoid-deserialization
Wondertan Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions p2p/subscriber.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,18 @@ func (s *Subscriber[H]) Broadcast(ctx context.Context, header H, opts ...pubsub.
if err != nil {
return err
}

opts = append(opts, pubsub.WithValidatorData(header))
return s.topic.Publish(ctx, bin, opts...)
}

func (s *Subscriber[H]) verifyMessage(ctx context.Context, p peer.ID, msg *pubsub.Message) (res pubsub.ValidationResult) {
if msg.ValidatorData != nil {
// means the message is local and was already validated
// so simply accept it
return pubsub.ValidationAccept
}

defer func() {
err := recover()
if err != nil {
Expand Down