perf(p2p): avoid deserialization for locally published headers#251
Merged
perf(p2p): avoid deserialization for locally published headers#251
Conversation
Wondertan
force-pushed
the
avoid-deserialization
branch
from
c8d2677 to
3715cf4
Compare
Closed
Wondertan
force-pushed
the
avoid-deserialization
branch
from
92cf688 to
4e3bf0c
Compare
Wondertan
requested review from
cristaloleg,
gupadhyaya,
renaynay,
tzdybal,
vgonkivs and
walldiss
as code owners
cristaloleg
previously approved these changes
Mar 26, 2025
Member
Author
|
So the assumption was that the existing test covers it, but it actually does publishing without calling |
Wondertan
force-pushed
the
avoid-deserialization
branch
from
8dd4328 to
77e7ea5
Compare
renaynay
approved these changes
Mar 31, 2025
cristaloleg
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on libp2p/go-libp2p-pubsub#603