ci(goreleaser): fix release candidate suffix (backport #3833) #3838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future.
The current
-rc*
prerelease_suffix was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the failing workflow. This resolves by removing the*
.Testing
Before
After
It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various tag_sort options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature.
This is an automatic backport of pull request #3833 done by Mergify.