v2.1.2 doesn't have prebuilt binaries attached #3819

rootulp · 2024-08-26T13:25:01Z

Context

The v2.1.2 release doesn't have prebuilt binaries attached

rootulp · 2024-08-30T03:12:34Z

Manually fixed the issue locally and uploaded binaries

Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future. The current `-rc*` [prerelease_suffix](https://goreleaser.com/customization/git/#git) was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the [failing workflow](https://github.com/celestiaorg/celestia-app/actions/runs/10523365886/job/29157983992#step:6:68). This resolves by removing the `*`. ## Testing 1. Worked on my fork: https://github.com/rootulp/celestia-app/releases/tag/v2.1.2 2. Worked on this repo: https://github.com/celestiaorg/celestia-app/releases/tag/v2.1.2 ### Before ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2-rc1 previous_tag=v2.1.2-rc0 dirty=true ``` ### After ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2 previous_tag=v2.1.2-rc0 dirty=true ``` It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various [tag_sort](https://goreleaser.com/customization/git/?h=tag_sort#git) options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature.

Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future. The current `-rc*` [prerelease_suffix](https://goreleaser.com/customization/git/#git) was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the [failing workflow](https://github.com/celestiaorg/celestia-app/actions/runs/10523365886/job/29157983992#step:6:68). This resolves by removing the `*`. ## Testing 1. Worked on my fork: https://github.com/rootulp/celestia-app/releases/tag/v2.1.2 2. Worked on this repo: https://github.com/celestiaorg/celestia-app/releases/tag/v2.1.2 ### Before ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2-rc1 previous_tag=v2.1.2-rc0 dirty=true ``` ### After ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2 previous_tag=v2.1.2-rc0 dirty=true ``` It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various [tag_sort](https://goreleaser.com/customization/git/?h=tag_sort#git) options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature. (cherry picked from commit 2931f15)

Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future. The current `-rc*` [prerelease_suffix](https://goreleaser.com/customization/git/#git) was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the [failing workflow](https://github.com/celestiaorg/celestia-app/actions/runs/10523365886/job/29157983992#step:6:68). This resolves by removing the `*`. ## Testing 1. Worked on my fork: https://github.com/rootulp/celestia-app/releases/tag/v2.1.2 2. Worked on this repo: https://github.com/celestiaorg/celestia-app/releases/tag/v2.1.2 ### Before ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2-rc1 previous_tag=v2.1.2-rc0 dirty=true ``` ### After ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2 previous_tag=v2.1.2-rc0 dirty=true ``` It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various [tag_sort](https://goreleaser.com/customization/git/?h=tag_sort#git) options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature.<hr>This is an automatic backport of pull request #3833 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>

rootulp added bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc labels Aug 26, 2024

rootulp mentioned this issue Aug 28, 2024

ci(goreleaser): fix release candidate suffix #3833

Merged

rootulp self-assigned this Aug 30, 2024

rootulp closed this as completed Aug 30, 2024

mergify bot mentioned this issue Aug 30, 2024

ci(goreleaser): fix release candidate suffix (backport #3833) #3838

Merged