Add support for Ed25519 #3
Conversation
santiagorodriguez96
changed the title
santiagorodriguez96
force-pushed
the
add-ed25519-support
branch
2 times, most recently
from
a098690 to
8a21069
Compare
| @@ -0,0 +1,57 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "ed25519" | |||
There was a problem hiding this comment.
Given we are not including this as a runtime dependency in the gemspec file (which I think is fine), users need to explicitly include this in their Gemfile for EdDSA to work.
We can do something a tiny bit more sophisticated to give the user a more helpful error message here if the gem not present. A good example is what activesupport does for the cache backends. See e.g. RedisCacheStore https://github.com/rails/rails/blob/fbe2433be6e052a1acac63c7faf287c52ed3c5ba/activesupport/lib/active_support/cache/redis_cache_store.rb#L3-L10.
| module OpenSSL | ||
| module SignatureAlgorithm | ||
| class EdDSA < Base | ||
| class Ed25519 |
There was a problem hiding this comment.
In the same vein as the curve argument comment, we can remove this class from the namespace for now.
| @@ -9,7 +9,7 @@ Gem::Specification.new do |spec| | |||
| spec.email = ["[email protected]"] | |||
| spec.license = "Apache-2.0" | |||
|
|
|||
| spec.summary = "ECDSA, RSA-PSS and RSA-PKCS#1 algorithms for ruby" | |||
| spec.summary = "ECDSA, EdDSA, RSA-PSS and RSA-PKCS#1 algorithms for ruby" | |||
| # frozen_string_literal: true | ||
|
|
||
| begin | ||
| gem "ed25519", ">= 1.0.0" |
There was a problem hiding this comment.
Reference: rails/rails#31134 (comment)
grzuy
force-pushed
the
add-ed25519-support
branch
3 times, most recently
from
d88f9a8 to
341c965
Compare
This commit attempts to close #2. Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to expose the required OpenSSL APIs in Ruby, expected to be released as 3.0 – See ruby/openssl#329. Once OpenSSL Ruby v3.0 is released, we could change the implementation in a way that users that use this gem alongside that version of OpenSSL will use the API provided by OpenSSL, but users with an older version of OpenSSL will still be provided with Ed25519 support with the use of RubyCrypto/ed25519
grzuy
force-pushed
the
add-ed25519-support
branch
from
341c965 to
2338eaf
Compare
What
This PR attempts to close #2.
How
Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to expose the required OpenSSL APIs in Ruby, expected to be released as 3.0 – See ruby/openssl#329.
Once
OpenSSL Rubyv3.0is released, we could change the implementation in a way that users that use this gem alongside that version ofOpenSSLwill use theAPIprovided byOpenSSL, but users with an older version ofOpenSSLwill still be provided withEd25519support with the use of RubyCrypto/ed25519.