Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide EdDSA #2

Closed
grzuy opened this issue Jul 11, 2020 · 0 comments · Fixed by #3
Closed

Provide EdDSA #2

grzuy opened this issue Jul 11, 2020 · 0 comments · Fixed by #3
Labels
enhancement New feature or request

Comments

@grzuy
Copy link
Contributor

grzuy commented Jul 11, 2020 •
edited
Loading

To keep it simple we can start by having no parameters, that is

OpenSSL::SignatureAlgorithm::EdDSA.new

and make it be Ed25519.

In the future we can consider Ed448.
@grzuy grzuy added the enhancement New feature or request label Jul 11, 2020
@santiagorodriguez96 santiagorodriguez96 mentioned this issue Aug 10, 2020
Merged
santiagorodriguez96 added a commit that referenced this issue Aug 10, 2020
@santiagorodriguez96
feat: add support for Ed25519
8a21069 
This commit attempts to close #2.

Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to
expose the required OpenSSL APIs in Ruby, expected to be released as 3.0
– See ruby/openssl#329.
Once OpenSSL Ruby v3.0 is released, we could change the implementation
in a way that users that use this gem alongside that version of OpenSSL
will use the API provided by OpenSSL, but users with an older version of
OpenSSL will still be provided with Ed25519 support with the use of
RubyCrypto/ed25519
grzuy pushed a commit that referenced this issue Feb 10, 2021
@santiagorodriguez96 @grzuy
feat: add support for Ed25519
694ad2b 
This commit attempts to close #2.

Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to
expose the required OpenSSL APIs in Ruby, expected to be released as 3.0
– See ruby/openssl#329.
Once OpenSSL Ruby v3.0 is released, we could change the implementation
in a way that users that use this gem alongside that version of OpenSSL
will use the API provided by OpenSSL, but users with an older version of
OpenSSL will still be provided with Ed25519 support with the use of
RubyCrypto/ed25519
grzuy pushed a commit that referenced this issue Feb 10, 2021
@santiagorodriguez96 @grzuy
feat: add support for Ed25519
d88f9a8 
This commit attempts to close #2.

Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to
expose the required OpenSSL APIs in Ruby, expected to be released as 3.0
– See ruby/openssl#329.
Once OpenSSL Ruby v3.0 is released, we could change the implementation
in a way that users that use this gem alongside that version of OpenSSL
will use the API provided by OpenSSL, but users with an older version of
OpenSSL will still be provided with Ed25519 support with the use of
RubyCrypto/ed25519
grzuy pushed a commit that referenced this issue Feb 10, 2021
@santiagorodriguez96 @grzuy
feat: add support for Ed25519
341c965 
This commit attempts to close #2.

Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to
expose the required OpenSSL APIs in Ruby, expected to be released as 3.0
– See ruby/openssl#329.
Once OpenSSL Ruby v3.0 is released, we could change the implementation
in a way that users that use this gem alongside that version of OpenSSL
will use the API provided by OpenSSL, but users with an older version of
OpenSSL will still be provided with Ed25519 support with the use of
RubyCrypto/ed25519
grzuy pushed a commit that referenced this issue Feb 10, 2021
@santiagorodriguez96 @grzuy
feat: add support for Ed25519
2338eaf 
This commit attempts to close #2.

Used the gem RubyCrypto/ed25519 as we still require ruby/openssl to
expose the required OpenSSL APIs in Ruby, expected to be released as 3.0
– See ruby/openssl#329.
Once OpenSSL Ruby v3.0 is released, we could change the implementation
in a way that users that use this gem alongside that version of OpenSSL
will use the API provided by OpenSSL, but users with an older version of
OpenSSL will still be provided with Ed25519 support with the use of
RubyCrypto/ed25519
@grzuy grzuy closed this as completed in #3 Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Ed25519 cedarcode/openssl-signature_algorithm
1 participant
@grzuy