Code cleanup for dangling file pointer investigation #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 46.88% 46.92% +0.03%
==========================================
Files 231 231
Lines 19166 19129 -37
Branches 2758 2745 -13
==========================================
- Hits 8986 8976 -10
+ Misses 9683 9658 -25
+ Partials 497 495 -2 |
graeme-winter
approved these changes
Feb 23, 2021
| @@ -1502,7 +1501,7 @@ def from_dict(obj, check_format=True, directory=None): | |||
| def from_json(string, check_format=True, directory=None): | |||
| """Decode a datablock from JSON string.""" | |||
| return DataBlockFactory.from_dict( | |||
| json.loads(string, object_hook=_decode_dict), | |||
| json.loads(string), | |||
There was a problem hiding this comment.
was the object_hook stuff really useless?
There was a problem hiding this comment.
on Python 3 it was a no-op
| @@ -1,14 +1,9 @@ | |||
| from __future__ import absolute_import, division, print_function | |||
|
|
||
| from dxtbx.model.crystal import CrystalFactory | ||
| from dxtbx.serialize.imageset import imageset_from_dict | ||
|
|
||
|
|
||
| def _decode_list(data): |
There was a problem hiding this comment.
this is only useless now we are in the future 👍
This was referenced Feb 23, 2021
Anthchirp
added a commit
that referenced
this pull request
Apr 22, 2021
Anthchirp
added a commit
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation into dials/dials#1603 found some superfluous programming motifs that made it unnecessarily difficult to figure out what is going on.