-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate datablock.*Diff pseudoclasses #302
Conversation
[skip ci] [ci skip]
Question here: There are a bunch more of these comparator "classes" ( They don't really have anything to do with datablocks or experiment lists. |
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 46.73% 46.74%
=======================================
Files 232 233 +1
Lines 19207 19221 +14
Branches 2763 2764 +1
=======================================
+ Hits 8977 8985 +8
- Misses 9733 9739 +6
Partials 497 497 |
Looks like no impact on my side if these classes are moved. |
to fix the Azure build
@graeme-winter You self-requested a review on this, I remember it had something to do with tolerance phil thingies. Do you want to add your 2p here or is this a separate PR? Otherwise this here is done - tests pass and everything. |
I think that this did not used to be the case? 🤔 |
There we go... I think this was what I was meaning - I think this is somewhat related but I am minded to make that a different pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scanned change set, did not see anything which would make future debuging harder and moving away from pseudoclasses is always a good thing, thank you for the work here.
Am slightly concerned by use of functools.partial
as an indicator of poor overall design, but that is out of context for this change set. I will raise an issue with my other concerns as raised in the conversation.
Previously deprecated in #302
BeamDiff
,ScanDiff
,GoniometerDiff
,DetectorDiff
,SequenceDiff
indxtbx.datablock
are replaced by functions indxtbx.model.compare
(beam_diff
, etc.)They don't really have anything to do with datablocks or experiment lists.