-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor add_two_photon_series
to add_photon_series
and add support for OnePhotonSeries
#462
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
85956d5
modify add_two_photon_series to add_photon_series to be able to add O…
weiglszonja 573e271
add tests
weiglszonja dbc62b1
add add_photon_series to init
weiglszonja ccfc814
add OnePhotonSeries to metadata_schema.json
weiglszonja f21ad1e
Merge branch 'main' into add_one_photon_series
weiglszonja b516756
refactor default ophys metadata functions
weiglszonja 4b946ec
Merge remote-tracking branch 'origin/add_one_photon_series' into add_…
weiglszonja edf47e9
update docsstring
weiglszonja 5307d30
Merge branch 'main' into add_one_photon_series
weiglszonja b88b314
refactor
weiglszonja 3959a17
Merge remote-tracking branch 'origin/add_one_photon_series' into add_…
weiglszonja 3fb0fef
conditionally require `photon_series_type` when metadata contains 'On…
weiglszonja e3b6169
refactor metadata in tests
weiglszonja 6071c08
fix assert
weiglszonja 026d7c0
Merge branch 'main' into add_one_photon_series
weiglszonja c819900
merge get_default_imaging_metadata into get_nwb_imaging_metadata
weiglszonja 9ed06f8
Merge branch 'main' into add_one_photon_series
CodyCBakerPhD ff7488b
remove pynwb constraint for python 3.11
weiglszonja 9d5a758
fix mask tests for numpy 1.24.2
weiglszonja bcdbcdd
update CHANGELOG.md
weiglszonja 6817990
deprecate two_photon_series_index
weiglszonja 011e618
pin pynwb to 2.3.2
weiglszonja d7ce2ff
change default two_photon_series_index to None
weiglszonja 18e66ee
remove constraint for numpy
weiglszonja 9ef96cf
Merge branch 'main' into add_one_photon_series
CodyCBakerPhD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what about numpy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do w/e you need to while attempting to loosen all versions
The numpy bounds might have been because of the same ROI test issue