Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add_two_photon_series to add_photon_series and add support for OnePhotonSeries #462

Merged
merged 25 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
85956d5
modify add_two_photon_series to add_photon_series to be able to add O…
weiglszonja May 30, 2023
573e271
add tests
weiglszonja May 30, 2023
dbc62b1
add add_photon_series to init
weiglszonja May 30, 2023
ccfc814
add OnePhotonSeries to metadata_schema.json
weiglszonja May 31, 2023
f21ad1e
Merge branch 'main' into add_one_photon_series
weiglszonja May 31, 2023
b516756
refactor default ophys metadata functions
weiglszonja Jun 1, 2023
4b946ec
Merge remote-tracking branch 'origin/add_one_photon_series' into add_…
weiglszonja Jun 1, 2023
edf47e9
update docsstring
weiglszonja Jun 1, 2023
5307d30
Merge branch 'main' into add_one_photon_series
weiglszonja Jun 1, 2023
b88b314
refactor
weiglszonja Jun 1, 2023
3959a17
Merge remote-tracking branch 'origin/add_one_photon_series' into add_…
weiglszonja Jun 1, 2023
3fb0fef
conditionally require `photon_series_type` when metadata contains 'On…
weiglszonja Jun 1, 2023
e3b6169
refactor metadata in tests
weiglszonja Jun 1, 2023
6071c08
fix assert
weiglszonja Jun 1, 2023
026d7c0
Merge branch 'main' into add_one_photon_series
weiglszonja Jun 5, 2023
c819900
merge get_default_imaging_metadata into get_nwb_imaging_metadata
weiglszonja Jun 5, 2023
9ed06f8
Merge branch 'main' into add_one_photon_series
CodyCBakerPhD Jun 6, 2023
ff7488b
remove pynwb constraint for python 3.11
weiglszonja Jun 6, 2023
9d5a758
fix mask tests for numpy 1.24.2
weiglszonja Jun 6, 2023
bcdbcdd
update CHANGELOG.md
weiglszonja Jun 6, 2023
6817990
deprecate two_photon_series_index
weiglszonja Jun 6, 2023
011e618
pin pynwb to 2.3.2
weiglszonja Jun 6, 2023
d7ce2ff
change default two_photon_series_index to None
weiglszonja Jun 6, 2023
18e66ee
remove constraint for numpy
weiglszonja Jun 6, 2023
9ef96cf
Merge branch 'main' into add_one_photon_series
CodyCBakerPhD Jun 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
* Added basic temporal alignment methods to the AudioInterface. `align_starting_time` is split into `align_starting_times` (list of times, one per audio file) and `align_global_starting_time` (shift all by a scalar amount). `align_by_interpolation` and other timestamp-based approaches is not yet implemented for this interface. [PR #402](https://github.com/catalystneuro/neuroconv/pull/402)
* Changed the order of recording properties extraction in `NeuroscopeRecordingInterface` and `NeuroScopeLFPInterface` to make them consistent with each other [PR #466](https://github.com/catalystneuro/neuroconv/pull/466)
* The `ScanImageImagingInterface` has been updated to read metadata from more recent versions of ScanImage [PR #457](https://github.com/catalystneuro/neuroconv/pull/457)
* Refactored `add_two_photon_series()` to `add_photon_series()` and added `photon_series_type` optional argument which can be either `"OnePhotonSeries"` or `"TwoPhotonSeries"`.
Changed `get_default_ophys_metadata()` to add `Device` and `ImagingPlane` metadata which are both used by imaging and segmentation.
Added `photon_series_type` to `get_nwb_imaging_metadata()` to fill metadata for `OnePhotonSeries` or `TwoPhotonSeries`. [PR #462](https://github.com/catalystneuro/neuroconv/pull/462)

### Testing
* The tests for `automatic_dandi_upload` now follow up-to-date DANDI validation rules for file name conventions. [PR #310](https://github.com/catalystneuro/neuroconv/pull/310)
Expand Down
6 changes: 2 additions & 4 deletions requirements-minimal.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
numpy>=1.22.0,<1.24;python_version<'3.11'
numpy>=1.22.0;python_version>='3.11'
numpy>=1.22.0
jsonschema>=3.2.0
PyYAML>=5.4
scipy>=1.4.1
h5py>=2.10.0
hdmf>=3.4.7
pynwb>=1.4.0;python_version>='3.8'
pynwb>=1.4.0,<2.3.2;python_version>='3.11'
pynwb==2.3.2;python_version>='3.8'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what about numpy?

numpy>=1.22.0,<1.24;python_version<'3.11'
numpy>=1.22.0;python_version>='3.11'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do w/e you need to while attempting to loosen all versions

The numpy bounds might have been because of the same ROI test issue

psutil>=5.8.0
tqdm>=4.60.0
dandi>=0.46.2
Expand Down
13 changes: 13 additions & 0 deletions src/neuroconv/schemas/metadata_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,19 @@
"imaging_plane": {"type": "string"}
}
}
},
"OnePhotonSeries": {
"type": "array",
"items": {
"title": "OnePhotonSeries",
"type": "object",
"required": ["name", "description"],
"properties": {
"name": {"type": "string", "default": "OnePhotonSeries"},
"description": {"type": "string"},
"imaging_plane": {"type": "string"}
}
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/neuroconv/tools/roiextractors/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
add_fluorescence_traces,
add_image_segmentation,
add_imaging_plane,
add_photon_series,
add_plane_segmentation,
add_summary_images,
add_two_photon_series,
check_if_imaging_fits_into_memory,
get_nwb_imaging_metadata,
get_nwb_segmentation_metadata,
Expand Down
Loading