Refactor add_two_photon_series to add_photon_series and add support for OnePhotonSeries
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nePhotonSeries to nwbfile
…one_photon_series
weiglszonja
changed the title
add_two_photon_series to add_photon_series and add support for OnePhotonSeries add_two_photon_series to add_photon_series and add support for OnePhotonSeries
weiglszonja
commented
Jun 1, 2023
weiglszonja
commented
Jun 1, 2023
weiglszonja
commented
Jun 6, 2023
| @@ -5,8 +5,7 @@ PyYAML>=5.4 | |||
| scipy>=1.4.1 | |||
| h5py>=2.10.0 | |||
| hdmf>=3.4.7 | |||
| pynwb>=1.4.0;python_version>='3.8' | |||
| pynwb>=1.4.0,<2.3.2;python_version>='3.11' | |||
| pynwb==2.3.2;python_version>='3.8' | |||
There was a problem hiding this comment.
But what about numpy?
numpy>=1.22.0,<1.24;python_version<'3.11'
numpy>=1.22.0;python_version>='3.11'
There was a problem hiding this comment.
Do w/e you need to while attempting to loosen all versions
The numpy bounds might have been because of the same ROI test issue
CodyCBakerPhD
approved these changes
Jun 6, 2023
|
@weiglszonja Thanks for getting this capability integrated! |
|
(the OpenEphys failure is unrelated to the numpy thing; I'll re-trigger it when the other runs complete) |
Codecov Report
@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 93 93
Lines 4338 4341 +3
=======================================
+ Hits 4001 4004 +3
Misses 337 337
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for adding data from
ImagingExtractorasOnePhotonSeriesto NWB fileadd_two_photon_seriestoadd_photon_seriesget_default_ophys_metadatato add Device and ImagingPlane metadata which are both used by imaging and segmentationphoton_series_typetoget_nwb_imaging_metadatawhich can be either "OnePhotonSeries" or "TwoPhotonSeries"get_default_segmentation_metadatato fill default additional metadata for segmentation