build(cmake): deduplicate library setup

[scarf005]

Summary

SUMMARY: Build "deduplicate setting up library for w/wo tiles in CMake"

Purpose of change

DRY is good

Describe the solution

• added setup_library function to setup common configuration
• also silenced DOWNLOAD_EXTRACT_TIMESTAMP warning

Describe alternatives you've considered

screm

Testing

was able to build tiles from source

[olanti-p]

I'm getting configure error after this

###:~/code/cata/a$ mkdir build
###:~/code/cata/a$ cd build
###:~/code/cata/a/build$ cmake ..
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done

 * Cataclysm: Bright Nights is a roguelike set in a post-apocalyptic world.
   _________            __                   .__                                
   \_   ___ \ _____   _/  |_ _____     ____  |  |   ___.__   ______  _____      
   /    \  \/ \__  \  \   __\\__  \  _/ ___\ |  |  <   |  | /  ___/ /     \     
   \     \____ / __ \_ |  |   / __ \_\  \___ |  |__ \___  | \___ \ |  Y Y  \    
    \______  /(____  / |__|  (____  / \___  >|____/ / ____|/____  >|__|_|  /    
           \/      \/             \/      \/        \/          \/       \/     
                                --= Bright Nights =--

 * https://github.com/cataclysmbnteam/Cataclysm-BN

--  build environment -- 

-- Build realm is                : Linux x86_64
-- CataclysmBN build version is : cbn-experimental-2023-09-02-1647-2-gfadcb9e60b4

-- CataclysmBN build options --

-- Found Git: /usr/bin/git (found version "2.34.1") 


-- Build  in development mode --

-- Binaries will be located in: /home/olanti/code/cata/a
-- GIT_BINARY                    : /usr/bin/git
-- DYNAMIC_LINKING               : ON
-- TILES                         : OFF
-- CURSES                        : ON
-- SOUND                         : OFF
-- LUA                           : OFF
-- BACKTRACE                     : ON
-- USE_HOME_DIR                  : ON

-- UNITY_BUILD                   : OFF
-- PCH_HEADER                    : OFF
-- LANGUAGES                     : all

-- See INSTALL file for details and more info --

-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Searching for Curses library --

-- Looking for wsyncup in /usr/lib/x86_64-linux-gnu/libcurses.so
-- Looking for wsyncup in /usr/lib/x86_64-linux-gnu/libcurses.so - found
-- Looking for cbreak in /usr/lib/x86_64-linux-gnu/libncursesw.so
-- Looking for cbreak in /usr/lib/x86_64-linux-gnu/libncursesw.so - found
-- Looking for nodelay in /usr/lib/x86_64-linux-gnu/libncursesw.so
-- Looking for nodelay in /usr/lib/x86_64-linux-gnu/libncursesw.so - found
-- Found Curses: /usr/lib/x86_64-linux-gnu/libncursesw.so  
CMake Error at src/CMakeLists.txt:4 (include):
  include could not find requested file:

    SetupLibrary.cmake


CMake Error at src/CMakeLists.txt:84 (setup_library):
  Unknown CMake command "setup_library".


-- Configuring incomplete, errors occurred!
See also "/home/olanti/code/cata/a/build/CMakeFiles/CMakeOutput.log".

[scarf005]

strange, the PR did add src/SetupLibrary.cmake.

[olanti-p]

False alarm, it was some VSCode git weirdness