Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of obsolete Castle.Core.Internal.Lock #576

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Replace usage of obsolete Castle.Core.Internal.Lock #576

merged 6 commits into from
Dec 4, 2020

Conversation

generik0
Copy link
Contributor

#565

  • Move castle.core.internal.lock into castle.widsor.core.internal.lock
    • Namespace will be core.internal.locking otherwise we get namespace conflicts
  • Update to castle.core 4.4.1

@generik0
Copy link
Contributor Author

Hi @jonorossi is this better for #565, i had to move the Lock files into a folder / sub-namespace, as the locks are still in 4.4.1 and the namespaces would be the same in both. Hence msbuild could not figure out what to use.

@generik0
Copy link
Contributor Author

hI @jonorossi I think we need to complete this PR before #572 as I expect it will give merge conflicts in the csproj. Best to fix in other branch, after this is completed

@generik0
Copy link
Contributor Author

generik0 commented Dec 2, 2020

@jonorossi sorry to be pushy. Is this good, can we compete, or need to think more?

@generik0
Copy link
Contributor Author

generik0 commented Dec 3, 2020

@jonorossi done

@jonorossi jonorossi linked an issue Dec 4, 2020 that may be closed by this pull request
Castle.Core has made Castle.Core.Internal.Lock obsolete #565
Closed
@jonorossi jonorossi changed the title Feature/565 move castle core lock Replace usage of obsolete Castle.Core.Internal.Lock Dec 4, 2020
@jonorossi jonorossi merged commit 51d7bf6 into castleproject:master Dec 4, 2020
@jonorossi jonorossi added this to the vNext milestone Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.

Castle.Core has made Castle.Core.Internal.Lock obsolete
2 participants
@generik0 @jonorossi