Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Castle.Core has made Castle.Core.Internal.Lock obsolete #565

Closed
generik0 opened this issue Nov 18, 2020 · 2 comments · Fixed by #576
Closed

Castle.Core has made Castle.Core.Internal.Lock obsolete #565

generik0 opened this issue Nov 18, 2020 · 2 comments · Fixed by #576
Milestone
v5.1.1

Comments

@generik0
Copy link
Contributor

generik0 commented Nov 18, 2020 •
edited
Loading

HI @jonorossi

Castle.Core has removed made Castle.Core.Internal.Lock obsolete. It is used in SimpleThreadSafeCollection and SimpleThreadSafeSet.
Recommends migration to System.Threading.ReaderWriterLockSlim that is also in net45++

Thoughts, should we migrate? Right now, the build will fail due to warning, if Castle.Core is updated.

EDIT: After pulling 4.4.1, Lock is actually removed, this change is required
@jonorossi
Copy link
Member

SimpleThreadSafeCollection should be changed to use a ReaderWriterLockSlim directly. We used to use the Lock class in Castle.Core because Silverlight doesn't have RWLS. There is no need for this abstraction anymore.

Castle.Core's SynchronizedDictionary (internal class) is an example of a class that no longer uses the Lock abstraction.

generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from SimpleThreadSafeCollection in benefit of ReaderWrite…
2f16ab6 
…rLockSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from InMemoryServiceCatalog in benefit of ReaderWriterLoc…
e9de148 
…kSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from SimpleThreadSafeDictionary in benefit of ReaderWrite…
6203294 
…rLockSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from SimpleThreadSafeSet in benefit of ReaderWriterLockSlim
619631c 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Refactor ToArray to less footprint not making a list and then an array.
63f8ce0 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from ListBasedLoadBalancePolicy in benefit of ReaderWrite…
43e4c6a 
…rLockSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Fix SimpleThreadSafeSet to Remove with ExitWriteLock in finally
bd02b36 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Fix SimpleThreadSafeDictionary to GetOrAdd with ExitUpgradeableReadLo…
7628eba 
…ck in finally

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from DiscoveryProxyCache in benefit of ReaderWriterLockSlim
499957e 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from WcfChannelHolder in benefit of ReaderWriterLockSlim
3c9e9e7 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from CallContextLifetimeScope in benefit of ReaderWriterL…
e5d7a79 
…ockSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from LifecycledComponentsReleasePolicy in benefit of Read…
63971da 
…erWriterLockSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from DefaultNamingSubSystem in benefit of ReaderWriterLoc…
d587f79 
…kSlim

castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Cleanup InMemoryServiceCatalog removing unneded code after new lock
e85de2c 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Remove Lock from DefaultPool in benefit of ReaderWriterLockSlim
003f313 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Fix SimpleThreadSafeSet incorrect Exit of lock
b9b2ea3 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 25, 2020
@generik0
Fix incorrect Exit of lock
49b1b58 
castleproject#565
@generik0
Copy link
Contributor Author

HI @jonorossi when you have time, please review PR

generik0 added a commit to generik0/Windsor that referenced this issue Nov 26, 2020
@generik0
Add disposal pattern to stop release from disposing again.
c657128 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 26, 2020
@generik0
Remove old lock used for testing
bf52a61 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 30, 2020
@generik0
Moved Castle.Core Lock into Castle.Core.Internal.Locking
240bf02 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Nov 30, 2020
@generik0
Update to Castle.Core 4.4.1
6fa21db 
castleproject#565
@generik0 generik0 mentioned this issue Nov 30, 2020
Merged
generik0 added a commit to generik0/Windsor that referenced this issue Dec 2, 2020
@generik0
Cleanup
f816765 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Dec 2, 2020
@generik0
Add SlimReadWriteLockTestCase and add required props
d415d3c 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Dec 2, 2020
@generik0
Removes Obsolete for test
aef3b46 
castleproject#565
generik0 added a commit to generik0/Windsor that referenced this issue Dec 3, 2020
@generik0
Move to Castle.MicroKernel.Internal
701dffe 
castleproject#565
@jonorossi jonorossi linked a pull request Dec 4, 2020 that will close this issue
Replace usage of obsolete Castle.Core.Internal.Lock #576
Merged
@jonorossi jonorossi added this to the vNext milestone Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging a pull request may close this issue.

Replace usage of obsolete Castle.Core.Internal.Lock generik0/Windsor
2 participants
@jonorossi @generik0