Update Castle.Core dependency to 4.0.0 #235
Conversation
…n Castle.Core AttributesUtil.cs)
| { | ||
| return (TAttribute[])Attribute.GetCustomAttributes(item, typeof(TAttribute), true); | ||
| return (TAttribute[])Attribute.GetCustomAttributes(item, typeof(TAttribute), inherit); |
There was a problem hiding this comment.
I changed this to avoid ambiguity because Castle.Core also has a GetAttributes() extension method, and it passes false for inherit
| @@ -307,7 +308,7 @@ private static AssemblyName GetAssemblyName(string filePath) | |||
| private static TBase Instantiate<TBase>(Type subtypeofTBase, object[] ctorArgs) | |||
| { | |||
| ctorArgs = ctorArgs ?? new object[0]; | |||
| var types = ctorArgs.ConvertAll(a => a == null ? typeof(object) : a.GetType()); | |||
There was a problem hiding this comment.
ConvertAll() extension method from Castle.Core (CollectionExtensions.cs) no longer exists.
There was a problem hiding this comment.
Have you considered creating a shim in windsor for it?
Something like this: https://github.com/cryosharp/fortress/blob/master/src/Fortress.Windsor/Compatibility/EnumerableExtensions.cs#L22
There was a problem hiding this comment.
Added EnumerableExtensions.cs
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
| static class EnumerableExtensions |
There was a problem hiding this comment.
Could you explicit mark this internal.
|
|
||
| static class EnumerableExtensions | ||
| { | ||
| public static Y[] ConvertAll<X, Y>(this X[] items, Func<X, Y> converter) |
There was a problem hiding this comment.
Could you change X/Y to T/TOutput, whatever the BCL convention is for this.
| results.Add(y); | ||
| } | ||
|
|
||
| return results.ToArray(); |
There was a problem hiding this comment.
Any idea how often this method can get called? Would be much nicer on the GC to allocate an array and populate it.
| public static void ForEach<X>(this IEnumerable<X> items, Action<X> action) | ||
| { | ||
| foreach (var item in items) | ||
| action(item); |
| return results.ToArray(); | ||
| } | ||
|
|
||
| public static void ForEach<X>(this IEnumerable<X> items, Action<X> action) |
| @@ -0,0 +1,42 @@ | |||
| // Copyright 2004-2011 Castle Project - http://www.castleproject.org/ | |||
| @@ -267,6 +267,9 @@ public void CanResolveClientAssociatedWithChannelUsingSuppliedModel() | |||
| } | |||
|
|
|||
| [Test] | |||
| #if DEBUG | |||
| [Ignore("This test fails in Debug / relies on GC.Collect to clean weak reference")] | |||
There was a problem hiding this comment.
This is somewhat worrying that GC.Collect no longer does what it says on the tin, we've never had a problem with this in the past. Any idea what has changed?
There was a problem hiding this comment.
As far as I know, in Debug mode the JIT will choose to keep the local variable alive until the end of the method, so that it can be inspected in the debugger. This is not new, it's likely this test was failing before.
|
🎉 🎉 🎉 |
ghost
mentioned this pull request
Changes: