Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castle.Core 4.x compatibility #227

Closed
gregsdennis opened this issue Apr 28, 2017 · 8 comments
Closed

Castle.Core 4.x compatibility #227

gregsdennis opened this issue Apr 28, 2017 · 8 comments
Milestone

Comments

@gregsdennis
Copy link

In #161 a bandaid was applied to the Nuget package to prevent upgrades to Castle.Core 4.x.

Are we going to see a version that is compatible?

@jonorossi
Copy link
Member

Yes, we are currently working to move our build processes to the new VS2017 tooling and move from TeamCity to AppVeyor. Once this work is done I'm planning to get a new release out that upgrades to Castle Core 4.0, is this currently blocking you?

@gregsdennis
Copy link
Author

Not blocking per se, but Moq > v4.7.0 depends on Core v4.x, so I'm stuck with lower versions until this is released.

Do you have a timeline?

@jonorossi
Copy link
Member

Ah, I thought Moq was still ILMerging Castle.Core.dll into Moq.dll, it looks like they are no longer doing that.

Timeline... should be in the next 2 weeks.

@jeremymeng
Copy link

I thought Moq was still ILMerging Castle.Core.dll into Moq.dll,

ILMerge doesn't work on .NET Core so we moved to depend on NuGet packages for both .NET Framework and .NET Core.

@dove
Copy link

dove commented May 16, 2017

NSubstitute 2 would appear to be in same boat as Moq, it now has Castle.Core >= 4 as a dependency where is had none in 1.*

@alinapopa
Copy link

Opened PR #235

@jonorossi jonorossi added this to the v4.0 milestone Jun 14, 2017
@gregsdennis
Copy link
Author

@jonorossi so is this resolved?

@ghost
Copy link

ghost commented Jun 29, 2017

@gregsdennis - Sorry I am jumping here, but yes it was resolved. We are preparing a release. Any day now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants