-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: enforce build for linux/riscv64 platform #73
cli: enforce build for linux/riscv64 platform #73
Conversation
🦋 Changeset detectedLatest commit: 42a2e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2ae8524
to
3ca76b7
Compare
I think this will break compatibility with current Dockerfiles out there, right? |
Yes. 🤔 What do you suggest? make it a And we should also update the applications-templates. |
I think it would be a minor. |
As this breaks Dockerfile compatibility let's put it together with other changes that changes Dockerfile, like the v2 initiative. |
3c6ea12
to
5388268
Compare
2264272
to
69f6a5e
Compare
Coverage Report for ./apps/cli
File Coverage
|
since the target is always a Cartesi Machine (riscv64), cartesi build should enforce the docker build environment via --platform argument
69f6a5e
to
60736db
Compare
Since the target is always a Cartesi Machine (riscv64), cartesi build should enforce the docker build environment via
--platform
argument.This way
Dockerfile
from cartesi/application-templates should be something like this.javascript
We should only need to define
--platform
when we want to run something on the host platform, for a cross-compilation or build stage that could be faster without the linux/riscv64 qemu of the docker builder.The example above uses the
$BUILDPLATFORM
, which is recommended so it will use the host platform.The second and last
FROM
doesn't need a--platform
since this will be enforced by thecartesi build
.