Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sdk #121

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Bump sdk #121

merged 1 commit into from
Oct 30, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Oct 30, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 822e516

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 31.4% 298 / 949
🔵 Statements 31.52% 303 / 961
🔵 Functions 37.41% 52 / 139
🔵 Branches 28.11% 122 / 434
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 89.28% 81.31% 96.87% 89.09% 67-68, 178, 228, 235, 244, 259-261, 260, 262, 273, 282, 284, 293, 331, 341-346, 343, 345, 357
Generated in workflow #211 for commit 822e516 by the Vitest Coverage Report Action

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small suggestion, won't block for it.

@@ -1,6 +1,6 @@
services:
anvil:
image: cartesi/sdk:0.12.0-alpha.0
image: cartesi/sdk:0.12.0-alpha.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we put this value in a environment variable in a single place?

https://github.com/cartesi/cli/blob/feature/bump-sdk/apps/cli/src/commands/run.ts#L102

At least for the cartesi run it would be useful.

@tuler tuler merged commit f922b64 into prerelease/v2-alpha Oct 30, 2024
3 checks passed
@tuler tuler deleted the feature/bump-sdk branch October 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants